feat: allow for lazy wallet initialization

[TimoGlastra]

• remove agent closeAndDeleteWallet as it was only used for tests. They now inject the wallet to close and delete
• make walletConfig and walletCredentials optional in InitConfig
• user can now manually initiale the wallet
• If agent is initialized and wallet is not yet initialized and no walletConfig and walletCredentials are available an error will be thrown

[codecov-commenter]

Codecov Report

Merging #331 (c2406ee) into main (ee81d01) will decrease coverage by 0.44%.
The diff coverage is 66.98%.

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   88.21%   87.77%   -0.45%     
==========================================
  Files         220      224       +4     
  Lines        4039     4113      +74     
  Branches      475      489      +14     
==========================================
+ Hits         3563     3610      +47     
- Misses        476      503      +27     

Impacted Files	Coverage Δ
src/types.ts	100.00% <ø> (ø)
src/wallet/error/WalletDuplicateError.ts	50.00% <50.00%> (ø)
src/wallet/IndyWallet.ts	74.82% <58.97%> (-12.39%)	⬇️
src/agent/Agent.ts	97.50% <92.30%> (-1.15%)	⬇️
src/wallet/error/WalletError.ts	100.00% <100.00%> (ø)
src/wallet/error/WalletNotFoundError.ts	100.00% <100.00%> (ø)
src/wallet/error/index.ts	100.00% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee81d01...c2406ee. Read the comment docs.

[jakubkoci]

I think it's good to have some "init" kind of method simplifying a lot of stuff for a developer. On the other hand, it would be good to provide some sort of flexibility out of the box (which we don't have to address in this PR of course).

[jakubkoci]

I'm note sure if this type has right cohesion. It seems these attributes are kind of unrealated, at least from the first point of view 🤷‍♂️

[TimoGlastra]

It contains related to an open wallet. I agree with your point, but would like to solve that in a separate PR.

I think we can make the wallet a bit more straightforward by splitsing the functionality in two parts:

• A "controller" or something that does the following
  • create
  • open
  • delete
  • close
• A wallet that does the actual wallet stuff. You need an open wallet to use it.

This will make it easier to handle multiple wallets I think and separates the lifecycle of a wallet from the usage of the wallet

I'd like to do that in a future PR

[jakubkoci]

Cool, good idea 👍

[TimoGlastra]

@jakubkoci made updates based on your feedback