Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need strategy for updating settings after constructing agent class #314

Closed
TimoGlastra opened this issue Jun 9, 2021 · 0 comments · Fixed by #331
Closed

Need strategy for updating settings after constructing agent class #314

TimoGlastra opened this issue Jun 9, 2021 · 0 comments · Fixed by #331

Comments

@TimoGlastra
Copy link
Contributor

In some flows it may be quite difficult to construct the agents with all config parameters already defined. This is easy from the point of AFJ, but in theory a lot of values could be delayed until later.

  • Wallet config and credentials is not necessary until init is called
  • genesis transactions / genesis path is not necessary until a connection with the ledger opnened
  • ...

We have a flow where we construct the agent, but do not have the wallet credentials yet. After this we fetch the wallet key from secure storage to unlock the wallet and only then we call the agent.init() method.


One solution would be to allow to pass extra config to the init method, but this would mean more validation, less explicit typing.

Another method is allow to update config values and handling those update in the framework. (not sure how to do that yet, but should be possible). This is probably more work, but also more dynamic.

I would like some input from others as this will require modifications to how the framework is initialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant