Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal ws outbound transporter #267

Conversation

TimoGlastra
Copy link
Contributor

add internal ws outbound transporter. Same as with HTTP. Next step is multi outbound transport support.

@TimoGlastra TimoGlastra requested a review from a team as a code owner May 12, 2021 15:31
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have not tested as of yet.

@TimoGlastra TimoGlastra force-pushed the small-transport-improvements branch from 670ea38 to ff94883 Compare May 14, 2021 07:08
@TimoGlastra TimoGlastra requested a review from jakubkoci May 14, 2021 07:11
Copy link
Contributor

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing serious, mainly just questions. Overall seems good 👍

src/agent/MessageSender.ts Show resolved Hide resolved
src/transport/WsOutboundTransporter.ts Show resolved Hide resolved
src/utils/ws.ts Show resolved Hide resolved
src/transport/WsOutboundTransporter.ts Outdated Show resolved Hide resolved
samples/mediator-ws.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #267 (05bff39) into main (60fc65f) will decrease coverage by 0.06%.
The diff coverage is 85.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   88.91%   88.84%   -0.07%     
==========================================
  Files         203      205       +2     
  Lines        3734     3793      +59     
  Branches      424      432       +8     
==========================================
+ Hits         3320     3370      +50     
- Misses        414      423       +9     
Impacted Files Coverage Δ
src/transport/HttpOutboundTransporter.ts 83.33% <0.00%> (-7.58%) ⬇️
src/transport/WsOutboundTransporter.ts 86.00% <86.00%> (ø)
src/agent/Agent.ts 98.59% <100.00%> (ø)
src/agent/MessageSender.ts 95.00% <100.00%> (ø)
src/transport/index.ts 100.00% <100.00%> (ø)
src/utils/ws.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fc65f...05bff39. Read the comment docs.

@TimoGlastra TimoGlastra force-pushed the small-transport-improvements branch from 0f36ecb to 05bff39 Compare May 14, 2021 09:05
@TimoGlastra TimoGlastra merged commit 2933207 into openwallet-foundation:main May 14, 2021
@TimoGlastra TimoGlastra deleted the small-transport-improvements branch May 14, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants