Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if URL already encoded #1485

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: check if URL already encoded #1485

merged 2 commits into from
Jun 15, 2023

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Jun 14, 2023

Check to make sure an URL is not already encoded before encoding it. If this happens it will create an erronious URL.

Fixes #1484

@jleach jleach requested a review from a team as a code owner June 14, 2023 17:18
@jleach
chore: code cleanup
fd92d79 
Signed-off-by: Jason C. Leach <[email protected]>
@TimoGlastra TimoGlastra changed the title chore: check if URL already encoded fix: check if URL already encoded Jun 15, 2023
@TimoGlastra TimoGlastra merged commit 38a0578 into openwallet-foundation:main Jun 15, 2023
@jleach jleach deleted the fix/no-re-encode-uri branch June 15, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert URL encoding or check if the URL is already encoded.
2 participants
@jleach @TimoGlastra