You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the issue I fixed in #1479 which was to protect agains spaces or other forbidden characters in tailsLocation has an edge case that is just as problematic. The fn encodeURI will re-encode a URI if it fines a % in it already. This can result in erroneous results and may be more problematic. To fix we can either remove the call to encodeURI added in #1479 or do a quick check to make sure its not already encoded:
Here is an example of the problem. Every time encodeURL is run the query string gets the % re-encoded as %25:
I think the issue I fixed in #1479 which was to protect agains spaces or other forbidden characters in tailsLocation has an edge case that is just as problematic. The fn
encodeURI
will re-encode a URI if it fines a%
in it already. This can result in erroneous results and may be more problematic. To fix we can either remove the call toencodeURI
added in #1479 or do a quick check to make sure its not already encoded:Here is an example of the problem. Every time
encodeURL
is run the query string gets the%
re-encoded as%25
:I can add a quick check like this:
Results in:
The text was updated successfully, but these errors were encountered: