Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection invitation fixes and improvements; support DID-based invitations #82

Merged
merged 9 commits into from
Jul 17, 2019
Merged

Connection invitation fixes and improvements; support DID-based invitations #82

merged 9 commits into from
Jul 17, 2019

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Jul 17, 2019 •
edited
Loading

  • Return a problem report when a connection invitation is submitted as an agent message
  • Remove support for connection invitations as HTTP GET requests
  • Rename parameters to --auto-accept-invites and --auto-accept-requests
  • Allow the creation and reception of public (DID-based) connection invitations when --public-invites is enabled
  • Publish the endpoint to the ledger when a public DID is used and the ledger is available

@andrewwhitehead
add --auto- to --accept-invites/accept-requests; change internal name…
f424e25 
…s for settings to indicate debug behaviour

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
return problem report when a connection invitation is received as an …
f729542 
…agent message; add tests to connection request and response handlers

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
remove support for connection invitations as HTTP GET requests
41ff443 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
do not create a public DID for alice
a32dfe8 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
support the creation and acceptance of public DID-based invitations (…
d518e90 
…requires --public-invites to enable)

Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead
disable routing in performance test by default
daf27d3 
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead andrewwhitehead requested a review from nrempel July 17, 2019 00:00
@codecov-io
Copy link

codecov-io commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #82 into master will increase coverage by 0.42%.
The diff coverage is 39.76%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   70.56%   70.98%   +0.42%     
==========================================
  Files         177      177              
  Lines        7429     7524      +95     
==========================================
+ Hits         5242     5341      +99     
+ Misses       2187     2183       -4

@andrewwhitehead andrewwhitehead changed the title Invitation fixes and improvements Connection invitation fixes and improvements; support DID-based invitations Jul 17, 2019
@nrempel
Copy link
Contributor

nrempel commented Jul 17, 2019

Looks good to me!

@nrempel nrempel merged commit b043d48 into openwallet-foundation:master Jul 17, 2019
@andrewwhitehead andrewwhitehead mentioned this pull request Aug 9, 2019
Closed
6 tasks
@andrewwhitehead andrewwhitehead deleted the invite-fixes branch February 29, 2020 21:45
cjhowland pushed a commit to cjhowland/aries-cloudagent-python that referenced this pull request Sep 8, 2022
@dbluhm
Merge pull request openwallet-foundation#82 from dbluhm/feature/crede…
ff84415 
…ntial-attachments-hashlinks

feat: hashlink helper endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrempel nrempel nrempel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewwhitehead @codecov-io @nrempel