-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default connection_id to None to account for Connectionless Proofs #2605
Conversation
Signed-off-by: Jamie Popkin <[email protected]>
Signed-off-by: Jamie Popkin <[email protected]>
Signed-off-by: Jamie Popkin <[email protected]>
Signed-off-by: Jamie Popkin <[email protected]>
Signed-off-by: Jamie Popkin <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatter can be a pain 😅 thanks for the contribution! Tests look good!
@swcurran is there someone on the BC Gov team that has looked at connection-less proofs recently that could spare a minute to check these changes? If not, I'm inclined to go ahead and merge. |
Maybe @esune or @andrewwhitehead would like to have a peak. 👀 |
@popkinj is on the BC Gov team, we triggered this change as we need to receive a problem report for a connection-less proof to handle proof rejection (for VC-AuthN specifically in our case). We are happy to merge! |
This is a small change in response to this issue and conversation.