Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default connection_id to None to account for Connectionless Proofs #2605

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

popkinj
Copy link
Contributor

@popkinj popkinj commented Nov 8, 2023

This is a small change in response to this issue and conversation.

@popkinj popkinj requested a review from dbluhm November 10, 2023 19:20
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatter can be a pain 😅 thanks for the contribution! Tests look good!

@dbluhm
Copy link
Contributor

dbluhm commented Nov 15, 2023

@swcurran is there someone on the BC Gov team that has looked at connection-less proofs recently that could spare a minute to check these changes?

If not, I'm inclined to go ahead and merge.

@popkinj
Copy link
Contributor Author

popkinj commented Nov 15, 2023

@swcurran is there someone on the BC Gov team that has looked at connection-less proofs recently that could spare a minute to check these changes?

If not, I'm inclined to go ahead and merge.

Maybe @esune or @andrewwhitehead would like to have a peak. 👀

@esune
Copy link
Member

esune commented Nov 15, 2023

@swcurran is there someone on the BC Gov team that has looked at connection-less proofs recently that could spare a minute to check these changes?

If not, I'm inclined to go ahead and merge.

@popkinj is on the BC Gov team, we triggered this change as we need to receive a problem report for a connection-less proof to handle proof rejection (for VC-AuthN specifically in our case). We are happy to merge!

@swcurran swcurran merged commit 31b6e0b into openwallet-foundation:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants