Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for connection-less problem reports for presentations #2597

Closed
esune opened this issue Nov 7, 2023 · 3 comments
Closed

Add support for connection-less problem reports for presentations #2597

esune opened this issue Nov 7, 2023 · 3 comments

Comments

@esune
Copy link
Member

esune commented Nov 7, 2023

When receiving a problem report on a connection-less proof request, ACA-Py considers it unsupported and raises an exception (see here.
This seems incorrect, and prevents the correct handling of rejected proof-requests (the verifier would not be able to know that a proof was rejected, and why).

Handling of the problem report should likely update the exchange record to "abort" it, and emit an event/webhook with relevant data for a controller to be able to reconcile it with the outgoing request.

@andrewwhitehead
Copy link
Contributor

Comparing receive_presentation to receive_problem_report, it looks like the handler just needs to be updated to pass None as the connection_id when there's no connection record.

@popkinj
Copy link
Contributor

popkinj commented Nov 8, 2023

Hey @esune
I'm no python expert... But...

Could it be as simple as changing this to something like this:

        connection_id = (
            None
            if oob_record
            else getattr(connection_record,'connection_id',None)
            if connection_record
            else None
        )

@esune
Copy link
Member Author

esune commented Nov 8, 2023

Hey @esune I'm no python expert... But...

Could it be as simple as changing this to something like this:

        connection_id = (
            None
            if oob_record
            else getattr(connection_record,'connection_id',None)
            if connection_record
            else None
        )

I think something like this should work 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants