Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .readthedocs.yaml file #2268

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Create .readthedocs.yaml file #2268

merged 2 commits into from
Jun 15, 2023

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Jun 14, 2023

Add readthedocs YAML file as required by RTD. Per this blog post, this file is now required for publishing the type of documentation we generate to the RTD sites. For those not aware, here is the link to the RTD site for ACA-Py -- https://aries-cloud-agent-python.readthedocs.io

Here is the link to the version of the docs generated from this branch with this new file: https://aries-cloud-agent-python.readthedocs.io/en/swcurran-add-rtd/. LGTM!

Add readthedocs YAML file as required by RTD.


Signed-off-by: Stephen Curran <[email protected]>
@swcurran swcurran marked this pull request as draft June 14, 2023 23:43
Adding sphinx option

Signed-off-by: Stephen Curran <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran marked this pull request as ready for review June 14, 2023 23:53
@swcurran swcurran requested a review from usingtechnology June 14, 2023 23:53
@usingtechnology
Copy link
Contributor

The added file looks good.

Do we care that there are broken links in the generated docs (broken links exist in current, so nothing to do with this PR - ex. the protocols link in "Developers that are interested in what DIDComm protocols are supported in ACA-Py should take a look at the protocols package.").

@swcurran swcurran merged commit 4a2503c into main Jun 15, 2023
@swcurran swcurran deleted the swcurran-add-rtd branch June 15, 2023 17:48
@swcurran
Copy link
Contributor Author

No — for this issue we don’t care about the broken links. Something we should address separately, but not in this issue.

@usingtechnology
Copy link
Contributor

Didn't think so, just wanted to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants