Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.7 and 3.10 unittests fix #2187

Merged
merged 24 commits into from
Apr 5, 2023
Merged

3.7 and 3.10 unittests fix #2187

merged 24 commits into from
Apr 5, 2023

Conversation

Jsyro
Copy link
Contributor

@Jsyro Jsyro commented Mar 29, 2023 •
edited
Loading

Disabled two tests related to this issue. Not sure on the resolution in the future.
#2072 (comment)

Updating two other dependencies resolved the other issues. See successful test run in my fork.
https://github.com/Jsyro/aries-cloudagent-python/actions/runs/4568725894/jobs/8064139393

shaangill025 and others added 18 commits March 29, 2023 14:05
@shaangill025 @Jsyro
check impl
539dfc0 
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: JSyro <[email protected]>
@chumbert @Jsyro
fix: askar exception message always displaying null DID
553b128 
Signed-off-by: Clément Humbert <[email protected]>
Signed-off-by: JSyro <[email protected]>
@shaangill025 @Jsyro
updates based on feedback
92e14de 
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Remove CircleCI Status since we aren't using CircleCI anymore
0c6a92e 
Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Delete circleci config file
ccfcaaf 
Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
0.8.0 release
a3d36aa 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Add this PR to the Changelog
82da386 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Fix lint warning on sphinx config
f35d070 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Change upgrade exception to be a print
c725ada 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Updated Changelog, removed change from RaiseError to print
6eb074e 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@ianco @Jsyro
Exit if upgrde version is the same as current
fda3faf 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: JSyro <[email protected]>
@ianco @Jsyro
Formatting issues
c78e4f3 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: JSyro <[email protected]>
@swcurran @Jsyro
Adds the upgrade command YML file to the PyPi Release
3362d9a 
Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: JSyro <[email protected]>
@Jsyro
update pytest to resolve the lineno issue on test collection
71768a3 
Signed-off-by: JSyro <[email protected]>
Signed-off-by: JSyro <[email protected]>
@Jsyro
remove unused import.
90dafb3 
Signed-off-by: JSyro <[email protected]>
@Jsyro
update rlp package.
6ab2f5d 
Signed-off-by: JSyro <[email protected]>
@Jsyro
disable for now.
18b3427 
Signed-off-by: JSyro <[email protected]>
@Jsyro
Merge remote-tracking branch 'Jsyro/main' into jsyro-main
10a25f8
@Jsyro Jsyro marked this pull request as ready for review March 29, 2023 21:10
@Jsyro Jsyro marked this pull request as draft March 30, 2023 20:02
@Jsyro
Copy link
Contributor Author

Jsyro commented Mar 30, 2023 •
edited
Loading

flake8 pytest and rlp library updates resolved the 3.7 and 3.10 issues. However there appear to be deprecation warnings that will become errors in python 3.11.2 (3.11.1 actually has a regression bug python/cpython#100098, so be aware of that).

I have only gotten the tests to pass, if there are more functional ways to ensure the app is working correctly, please share so I can do that.

@Jsyro Jsyro changed the title 3.10 unittests fix 3.7 and 3.10 unittests fix Mar 30, 2023
@Jsyro Jsyro marked this pull request as ready for review March 30, 2023 20:44
@swcurran swcurran requested review from burdettadam and dbluhm March 30, 2023 20:48
@swcurran
Copy link
Contributor

@burdettadam @dbluhm — could you please take a look at this one and provide a review? @Jsyro is a new member of the ACA-Py team, but has been building Traction on top of ACA-Py for some time. This is his intro task — to eliminate the nightly warnings about the 3.7 and 3.10 tests failing.

He is also looking at what to do about the asynctest problem — the library is deprecated. We need to come up with a community decision of what to do that that and how. See #1717 for details.

@swcurran
Copy link
Contributor

That was fast, @dbluhm ! 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit 0343728 into openwallet-foundation:main Apr 5, 2023
@Gavinok Gavinok mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbluhm dbluhm dbluhm approved these changes

@burdettadam burdettadam Awaiting requested review from burdettadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jsyro @swcurran @dbluhm @shaangill025 @chumbert @ianco