Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate errors in daily Python 3.7 and Python 3.10 errors #2072

Closed
swcurran opened this issue Jan 10, 2023 · 7 comments
Closed

Investigate errors in daily Python 3.7 and Python 3.10 errors #2072

swcurran opened this issue Jan 10, 2023 · 7 comments
Assignees

Comments

@swcurran
Copy link
Contributor

swcurran commented Jan 10, 2023

We are running the integration tests for Python 3.6 - 3.10 and currently we are getting errors for Python 3.7 and Python 3.10.

Investigate the errors and solve at least the 3.10 issue, and ideally both.

Example error run here

@swcurran
Copy link
Contributor Author

@Jsyro — here is the task for you to look at. I’ll see if I can make you an assignee, and will be adding you to the Hyperledger organization so that for sure you can be added to future tickets.

@Jsyro
Copy link
Contributor

Jsyro commented Mar 27, 2023

Initial investigation:

3.10 (INDY and normal), assertion library TypeError: required field "lineno" missing from alias. possible breaking change or library dependency issue.

3.7 (INDY and normal), Flake 8 is checking and thinks it's finding attribute errors, maybe it's legit, but probably there is a type checking issue with this error.E AttributeError: 'EntryPoints' object has no attribute 'get'

@Jsyro
Copy link
Contributor

Jsyro commented Mar 28, 2023

TypeError: required field "lineno" missing from alias was fixed with an update to the pytest library.

pytest-dev/pytest#9195.

@Jsyro
Copy link
Contributor

Jsyro commented Mar 28, 2023

The code uses the asynctest package which has not been updated since May 2019, https://pypi.org/project/asynctest/#history.

Which internally uses deprecated version of defining async functions. The 3.8 and 3.9 test results include the relevant deprecation warning to use async def instead.

Rapptz/discord.py#375 (comment)

Looks like we will need to refactor out that library for find a suitable replacement.

@swcurran
Copy link
Contributor Author

Ouch — that sounds terrifying. See image:

image

@andrewwhitehead
Copy link
Contributor

Related: #1717

@Jsyro
Copy link
Contributor

Jsyro commented Mar 29, 2023

Tests rely on this library, https://github.com/nvllsvm/async_case.... which is incompatible with newer versions of asyncio that do not accept the loop parameter in the gather() method.

https://docs.python.org/3.10/whatsnew/3.10.html#changes-in-the-python-api

Unsure how to proceed, could update the lib, but unclear if that would break older versions, could refactor and remove dependency on the library, but the related tests are quite dense.

https://github.com/hyperledger/aries-cloudagent-python/blob/67da623e65587929fbbba04ed052864dbf8c7c32/aries_cloudagent/admin/tests/test_admin_server.py

This was referenced Mar 29, 2023
@swcurran swcurran added this to the Frameworks Sprint 1 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants