-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete tail files #2103
Merged
ianco
merged 7 commits into
openwallet-foundation:main
from
DTCoE-CGI:delete-tail-files
Feb 15, 2023
Merged
Delete tail files #2103
ianco
merged 7 commits into
openwallet-foundation:main
from
DTCoE-CGI:delete-tail-files
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramreddychalla94
force-pushed
the
delete-tail-files
branch
from
February 1, 2023 15:13
666f52d
to
a0621a0
Compare
Signed-off-by: ram.challa <[email protected]>
Signed-off-by: ram.challa <[email protected]>
Signed-off-by: ram.challa <[email protected]>
FYI there are some code format issues and a couple of unit tests failing. |
Signed-off-by: pradeepp88 <[email protected]>
@ianco I have fixed the failing test cases and code formatting. @ramreddychalla94 has also created a new unit test class. Please review the code and let us know if they are ok. Thanks. |
ianco
approved these changes
Feb 15, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to add an endpoint to delete the tails file based on cred_def_id or rev_reg_id under revocation protocol. This is done to clean up the local tails file after uploading it to tails server. Looking for the feedback from the community.
-Signed off by: ramreddychalla94 [email protected]
-Funded by the Ontario Government