Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tail files #2103

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Conversation

ramreddychalla94
Copy link
Contributor

@ramreddychalla94 ramreddychalla94 commented Jan 31, 2023

Creating this PR to add an endpoint to delete the tails file based on cred_def_id or rev_reg_id under revocation protocol. This is done to clean up the local tails file after uploading it to tails server. Looking for the feedback from the community.
-Signed off by: ramreddychalla94 [email protected]
-Funded by the Ontario Government

@ramreddychalla94
Copy link
Contributor Author

ramreddychalla94 commented Feb 1, 2023

This PR resolves #2032 @swcurran please review and let us know of your comments, thanks.
This is also a follow up from #2061.

Signed-off-by: ram.challa <[email protected]>
@ianco
Copy link
Contributor

ianco commented Feb 13, 2023

FYI there are some code format issues and a couple of unit tests failing.

@pradeepp88
Copy link
Contributor

@ianco I have fixed the failing test cases and code formatting. @ramreddychalla94 has also created a new unit test class. Please review the code and let us know if they are ok. Thanks.

@ianco ianco enabled auto-merge February 15, 2023 21:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco merged commit ed3d739 into openwallet-foundation:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants