Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added functionality to delete tails file #2061

Closed
wants to merge 0 commits into from
Closed

added functionality to delete tails file #2061

wants to merge 0 commits into from

Conversation

ramreddychalla94
Copy link
Contributor

added an endpoint to delete tails file on the basis of either cred_def_id or rev_reg_id

@pradeepp88
Copy link
Contributor

pradeepp88 commented Dec 23, 2022 •
edited
Loading

This PR resolves #2032 @swcurran please review and let us know of your comments, thanks.

ianco
ianco requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, can you check the code formatting issues?

@ramreddychalla94 ramreddychalla94 force-pushed the main branch 2 times, most recently from 6738bf1 to 6129dde Compare January 5, 2023 19:27
@ianco
Copy link
Contributor

ianco commented Jan 5, 2023

2 files are failing the black formatting checks (you can run black aries_cloudagent locally to fix)

unit tests are failing (run ./scripts/run_tests_indy locally to see the errors)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramreddychalla94 ramreddychalla94 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianco ianco ianco requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramreddychalla94 @pradeepp88 @ianco