Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Multiple Credential Issuance [v2.1] #2088

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 commented Jan 24, 2023

Signed-off-by: Shaanjot Gill [email protected]

  • Ran black code formatter with version 23.1.0 to pass the check, all file changes outside ./aries_cloudagent/protocols/issue_credential/v2_0 directory and aries_cloudagent/config/argparse.py [22 files] were triggered by this. A special case [collision between flake8 and black 23.1.0] needed to be handled in aries_cloudagent/ledger/indy.py.
  • resolves Add support for Issue Credential 2.1 -- Issuer and Holder #1979
  • pending final Admin API testing and addition of integration tests [I can maybe leave this for a separate PR (combine tests for both issue-cred and present-proof 2.1)]

@shaangill025 shaangill025 added this to the Version 1.0.0 milestone Jan 24, 2023
@shaangill025 shaangill025 force-pushed the issue_cred_2.1 branch 3 times, most recently from bf6d044 to a35e06a Compare February 1, 2023 22:16
@shaangill025 shaangill025 marked this pull request as ready for review February 2, 2023 17:07
@ianco
Copy link
Contributor

ianco commented Feb 2, 2023

  • pending final Admin API testing and addition of integration tests [I can maybe leave this for a separate PR (combine tests for both issue-cred and present-proof 2.1)]

I think this is fine to put into a separate PR

Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
shaangill025 and others added 14 commits February 3, 2023 14:46
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
…olver-return-schema

fix: resolver api schema inconsistency
Signed-off-by: Stephen Curran <[email protected]>
swcurran and others added 13 commits February 10, 2023 12:52
- Trigger when releases and prereleases are published.

Signed-off-by: Wade Barnes <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
- Trigger when releases and prereleases are published.

Signed-off-by: Wade Barnes <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
@shaangill025 shaangill025 changed the base branch from main to issue_cred_pres_proof_2.1 February 13, 2023 16:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

aries_cloudagent/config/argparse.py Show resolved Hide resolved
@ianco ianco merged commit 725faf7 into openwallet-foundation:issue_cred_pres_proof_2.1 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Issue Credential 2.1 -- Issuer and Holder
6 participants