Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include image_url in oob invitation #1966

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

Zzocker
Copy link
Contributor

@Zzocker Zzocker commented Oct 6, 2022

include image_url in out-of-band invitations.

Signed-off-by: Pritam Singh [email protected]

@swcurran swcurran requested review from shaangill025 and ianco October 6, 2022 15:37
@shaangill025
Copy link
Contributor

shaangill025 commented Oct 6, 2022

@Zzocker
Copy link
Contributor Author

Zzocker commented Oct 6, 2022

@shaangill025 oh, I missed out when use_public_did=true, amended the commit, and forced pushed it.

@shaangill025
Copy link
Contributor

@Zzocker You are missing a trailing , [should be image_url=image_url,] at https://github.com/hyperledger/aries-cloudagent-python/blob/075a2d184ad0575fcbe514094fdbecbb04e24a97/aries_cloudagent/protocols/out_of_band/v1_0/manager.py#L239

You can run python -m black ./aries_cloudagent inside aries-cloudagent-python directory to check and fix formatting issues.

@swcurran
Copy link
Contributor

Can you please update the this PR?

@swcurran
Copy link
Contributor

Apologies -- I didn't get this merged before another came through. I'm not sure why I can't update the base branch, but if you could do that, I'll get this merged. Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit 06829f6 into openwallet-foundation:main Oct 18, 2022
@Zzocker Zzocker deleted the image_url branch October 18, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants