Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ImageURL in invitation #751

Closed
ankitkr1606 opened this issue Oct 13, 2020 · 5 comments
Closed

Include ImageURL in invitation #751

ankitkr1606 opened this issue Oct 13, 2020 · 5 comments

Comments

@ankitkr1606
Copy link

I was trying to include ImageURL in the invitation while using create_invitation REST API but was not able to. Can you help me in this?

@ankitkr1606 ankitkr1606 changed the title Include ImagrURL in invitation Include ImageURL in invitation Oct 13, 2020
@ankitkr1606
Copy link
Author

ankitkr1606 commented Oct 15, 2020

As of now when I create invitation using Swagger agents the response I get is something like this.
invi

But as shown in the example of create invitation we can even include an attribute called ImageURL as can be seen here
ex_invi

I want to include this into the invitation. I looked at the code base but was not able to find that image_url variable has been assigned any value.

@swcurran
Copy link
Contributor

The use of icons in invitations has some interesting tension to it -- we want it to improve the user experience, but we want to be careful to make sure a "self-asserted" image (no verification of the sender) can't be used to fool a user into thinking a connection is with one party when it isn't. People pretending to be the Bank when they aren't and they are trying to scam people. An invitation rightly has no trust between the parties, and that trust should be built up using the connection process.

All that said, a PR could be created, if you are interested.

@kfigaj
Copy link

kfigaj commented Mar 24, 2022

@ankitkr1606 did you try to set this parameter at the agent start?

--image-url IMAGE_URL
Specifies the image url for this agent. This image url
is publicized (self-attested) to other agents as part
of forming a connection. [env var: ACAPY_IMAGE_URL]

@swcurran
Copy link
Contributor

swcurran commented Jun 3, 2022

Related to #1686 which is the same issue but for the OOB/DID Exchange protocols. This one is for connections.

@swcurran
Copy link
Contributor

This was added for OOB in PR #1966 . Closing this and will close #1686 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants