Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust revocation registry update procedure to shorten transactions #1804

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

@andrewwhitehead andrewwhitehead force-pushed the fix/revoc-txn branch 5 times, most recently from 012d718 to 8cffd7a Compare June 13, 2022 23:20
@ianco ianco added the 0.7.4 label Jun 14, 2022
@ianco
Copy link
Contributor

ianco commented Jun 14, 2022

I get a couple of integration tests failing with askar:

Failing scenarios:
features/0454-present-proof.feature:118 Present Proof for multiple credentials where the one is revocable and one isn't -- @1.1
features/0454-present-proof.feature:139 Present Proof for multiple credentials where the one is revocable and one isn't, and the revocable credential is revoked -- @1.1

@andrewwhitehead
Copy link
Contributor Author

@ianco The integration tests passed on the latest run, but I don't think the failures were very consistent. Are you able to run it again?

@swcurran
Copy link
Contributor

@andrewwhitehead -- I'm assuming you are running this with Askar and Indy?

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1804 (dd7d074) into main (6199dd8) will decrease coverage by 0.01%.
The diff coverage is 69.84%.

@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
- Coverage   93.75%   93.74%   -0.02%     
==========================================
  Files         534      534              
  Lines       33822    33846      +24     
==========================================
+ Hits        31711    31728      +17     
- Misses       2111     2118       +7     

@andrewwhitehead andrewwhitehead marked this pull request as ready for review June 15, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants