Allow use of SEED when creating local wallet DID Issue-1682 #1705
Conversation
Signed-off-by: DaevMithran <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 528 528
Lines 32933 32939 +6
==========================================
+ Hits 31385 31389 +4
- Misses 1548 1550 +2 |
|
This looks good!
|
| if context.settings.get("wallet.allow_insecure_seed"): | ||
| seed = body.get("seed") or None |
There was a problem hiding this comment.
Would be good to throw an error if a seed is provided and wallet.allow_insecure_seed is not enable to make it more clear to the end user the seed is not used. This can give the false sense the seed is being used to create the did.
| @@ -355,13 +355,20 @@ async def wallet_create_did(request: web.BaseRequest): | |||
| f" support key type {key_type.key_type}" | |||
| ) | |||
| ) | |||
| seed = None | |||
There was a problem hiding this comment.
The seed property is not added to the DIDCreateSchema making it harder to discover from the swagger ui and it won't be included when generating clients from the swagger file.
There was a problem hiding this comment.
I don't think we should advertise the seed parameter unless the startup parameter is set.
So we need to either make the seed optional based on the parameter (i.e. doesn't show in swagger if not set), or else we need to break out a separate endpoint that is enabled with --wallet-allow-insecure-seed
swcurran
changed the title
Some questions around