Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of SEED when creating local wallet DID #1682

Closed
ianco opened this issue Mar 22, 2022 · 8 comments
Closed

Allow use of SEED when creating local wallet DID #1682

ianco opened this issue Mar 22, 2022 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@ianco
Copy link
Contributor

ianco commented Mar 22, 2022

Update the /wallet/did/create endpoint to allow the use of an optional SEED when creating a new local DID

Add a new startup parameter --allow-insecure-seed-local-did to enable the use of this new SEED parameter (if the option is not provided on startup then the SEED parameter will not be available when creating a local DID.

Consider as well providing a way to import an explicit public/private key pair (vs. indirectly via a seed) so that an existing key pair can be imported into an Aries Wallet.

See Issue #1657 for the background discussion

@ianco ianco added the help wanted Extra attention is needed label Mar 22, 2022
@tdiesler
Copy link
Contributor

tdiesler commented Apr 1, 2022

#606 may also be related

@DaevMithran
Copy link
Contributor

DaevMithran commented Apr 6, 2022

@ianco this has been resolved

@tdiesler
Copy link
Contributor

tdiesler commented Apr 6, 2022

@DaevMithran please show how this can now be done

@DaevMithran
Copy link
Contributor

DaevMithran commented Apr 6, 2022

@tdiesler
I added wallet startup parameter: --wallet-allow-insecure-seed which will support a seed in body of wallet/did/create route

The seed is not added in schema of wallet/did/create route as it can create confusion.

@tdiesler
Copy link
Contributor

tdiesler commented Apr 6, 2022

image

... "seed" as top level attribute or as an option?

@matgnt
Copy link
Contributor

matgnt commented Apr 6, 2022

Just as a reference for others, it seems the change has been merged in PR #1705

@DaevMithran
Copy link
Contributor

@tdiesler seed is a top level attribute

@tdiesler
Copy link
Contributor

tdiesler commented Apr 6, 2022

@DaevMithran merci

@swcurran swcurran closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants