Fix: present-proof v2 send-proposal [issue#1474]

[shaangill025]

Signed-off-by: Shaanjot Gill [email protected]

resolve #1474

[andrewwhitehead]

Setting an argument default value to an object is generally not a good idea, because each call to the function will receive the same object. I think this method and create_pres should default to None and handle that appropriately.

[shaangill025]

Updated request_data dict to default to None for create_bound_request and create_pres methods.

[swcurran]

Is the failing test related to this change, or something in the overall flow?

[andrewwhitehead]

@swcurran The two errors appear to be due to the ursa_bbs_signatures library not being found when executing the integration tests?

[swcurran]

So a configuration error in the integration suite, I gather? Who can look at this -- @shaangill025, I assume, or perhaps @ianco in the integration suite setup?

[andrewwhitehead]

Actually it's stranger than that.. ursa_bbs_signatures is installed but it can't find the binary shared library that comes with it (at least I think it does). I don't think this would be affected by the addition of --platform in #1697 so maybe the GHA base image was updated?

[shaangill025]

Yes, I think the integration tests have begun failing since PR #1697 merge about 2 hours back [includes merged #1676]. The last successful tests are with #1696 merge about 4 hours back.
Error:

File "/home/indy/aries_cloudagent/wallet/bbs.py", line 103, in create_bls12381g2_keypair
7hAries      |     key_pair = BlsKeyPair.generate_g2(seed)
7hAries      |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/ursa_bbs_signatures/models/keys/BlsKeyPair.py", line 65, in generate_g2
7hAries      |     res = bls_generate_g2_key(seed)
7hAries      |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/ursa_bbs_signatures/_ffi/bindings/bls.py", line 78, in bls_generate_g2_key
7hAries      |     POINTER(ExternError),
7hAries      |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/ursa_bbs_signatures/_ffi/ffi_util.py", line 41, in wrap_native_func
7hAries      |     lib_func = getattr(get_library(), function_name)
7hAries      |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/ursa_bbs_signatures/_ffi/ffi_util.py", line 56, in get_library
7hAries      |     LIB = _load_library("bbs")
7hAries      |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/ursa_bbs_signatures/_ffi/ffi_util.py", line 84, in _load_library
7hAries      |     raise FfiException(f"Library not found in path: {lib_path}")
7hAries      | ursa_bbs_signatures._ffi.FfiException.FfiException: Library not found in path: None
7hAries      | 
7hAries      | The above exception was the direct cause of the following exception:
7hAries      | 
7hAries      | Traceback (most recent call last):
7hAries      |   File "/home/indy/aries_cloudagent/wallet/routes.py", line 364, in wallet_create_did
7hAries      |     info = await wallet.create_local_did(method=method, key_type=key_type)
7hAries      |   File "/home/indy/aries_cloudagent/wallet/indy.py", line 455, in create_local_did
7hAries      |     method, key_type, metadata, seed
7hAries      |   File "/home/indy/aries_cloudagent/wallet/indy.py", line 385, in __create_keypair_local_did
7hAries      |     public_key, secret_key = create_keypair(key_type, validate_seed(seed))
7hAries      |   File "/home/indy/aries_cloudagent/wallet/crypto.py", line 46, in create_keypair
7hAries      |     return create_bls12381g2_keypair(seed)
7hAries      |   File "/home/indy/aries_cloudagent/wallet/bbs.py", line 106, in create_bls12381g2_keypair
7hAries      |     raise BbsException("Unable to create keypair") from error
7hAries      | aries_cloudagent.wallet.bbs.BbsException: Unable to create keypair

[shaangill025]

I ran integration tests locally on PR #1675 which was merged 8 days back [also #1696 merged 5 hours back] and I get the same error, looks like an issue with the ursa-bbs-signatures package itself.

[swcurran]

Please keep pushing on this -- we need to get it resolved.

[shaangill025]

I have fixed the ursa_bbs_signatures._ffi.FfiException.FfiException: Library not found in path: None error . ursa-bbs-signatures 1.0.2 was released yesterday which is when tests started failing. As a temporary fix, I have fixed it to 1.0.1 which is working.

[karimStekelenburg]

I have just deleted the ursa-bbs-signatures 1.0.2 release from PyPi, so hopefully this resolved the issue.

[shaangill025]

@andrewwhitehead No change was made since the last time you approved this. Locking ursa-bbs-signature change was reverted as 1.0.2 release was deleted from PyPi.

[ianco]

LGTM