Fix usage of send_credential_ack

[andrewwhitehead]

Follow up to #1619

[codecov-commenter]

Codecov Report

Merging #1653 (0bb6748) into main (dd67ba6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         528      528           
  Lines       32737    32737           
=======================================
  Hits        31267    31267           
  Misses       1470     1470           

[swcurran]

From my testing this does not fix the errors on AATH, but check my process and results. It looks like it is different:

• ./manage rebuild -a acapy-main
• ./manage run -d acapy-main -r allure -t @AcceptanceTest -t @AIP10 -t ~@wip
• edit https://github.com/hyperledger/aries-agent-test-harness/blob/main/aries-backchannels/acapy/requirements-main.txt and change the fork/branch to aries-cloudagent[indy, bbs, askar]@git+https://github.com/andrewwhitehead/aries-cloudagent-python@fix/send-cred-ack-result
• ./manage rebuild -a acapy-main
• ./manage run..../manage run -d acapy-main -r allure -t @AcceptanceTest -t @AIP10 -t ~@wip`

Same set of test fail:

Executing tests with Allure Reports.
features/0036-issue-credential.feature  FFFF
features/0037-present-proof.feature  FFFFFFFFFFFFF
features/0160-connection.feature  ..

Error in main branch:

AssertionError: FAILED SUB-STEP: Given "Bob" has an issued credential from Acme\nSubstep info: Assertion Failed: FAILED SUB-STEP: And "Bob" acknowledges the credential issue\nSubstep info: Assertion Failed: resp_status 500 is not 200; 500 Internal Server Error\n\nServer got itself in trouble\nTraceback (of failed substep):\n File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run\n match.run(runner.context)\n File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run\n self.func(context, *args, **kwargs)\n File "features/steps/0036-issue-credential.py", line 383, in step_impl\n assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"\n\nTraceback (of failed substep):\n File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run\n match.run(runner.context)\n File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run\n self.func(context, *args, **kwargs)\n File "features/steps/0037-present-proof.py", line 123, in step_impl\n context.execute_steps(context_steps)\n File "/usr/local/lib/python3.7/site-packages/behave/runner.py", line 404, in execute_steps\n assert False, message\n\n",

Error in Andrew's:

"AssertionError: FAILED SUB-STEP: Given "Bob" has an issued credential from Acme\nSubstep info: Assertion Failed: FAILED SUB-STEP: And "Bob" acknowledges the credential issue\nSubstep info: Traceback (most recent call last):\n File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run\n match.run(runner.context)\n File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run\n self.func(context, *args, **kwargs)\n File "features/steps/0036-issue-credential.py", line 385, in step_impl\n assert resp_json["state"] == "done"\nAssertionError\n\nTraceback (of failed substep):\n File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run\n match.run(runner.context)\n File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run\n self.func(context, *args, **kwargs)\n File "features/steps/0036-issue-credential.py", line 385, in step_impl\n assert resp_json["state"] == "done"\n\nTraceback (of failed substep):\n File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run\n match.run(runner.context)\n File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run\n self.func(context, *args, **kwargs)\n File "features/steps/0037-present-proof.py", line 123, in step_impl\n context.execute_steps(context_steps)\n File "/usr/local/lib/python3.7/site-packages/behave/runner.py", line 404, in execute_steps\n assert False, message\n\n",

[andrewwhitehead]

@swcurran According to that it was throwing a 500 error from the API, and is now returning a different state than expected which is an improvement!

[swcurran]

I did see there isn’t a 500. Should we merge this and keep trying.