Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): several fixes for js wrapper #111

Merged
merged 13 commits into from
Mar 7, 2023
Merged

fix(js): several fixes for js wrapper #111

merged 13 commits into from
Mar 7, 2023

Conversation

TimoGlastra
Copy link
Contributor

This PR contains several fixes from integrating aries askar into react native.

Mainly it resolves:

Draft as it still needs to be tested fully in React Native

This was referenced Mar 6, 2023
Merged
Merged
@TimoGlastra TimoGlastra linked an issue Mar 7, 2023 that may be closed by this pull request
[JS Wrapper] Custom error thrown when no entries found #77
Closed
@TimoGlastra TimoGlastra mentioned this pull request Mar 7, 2023
Closed
@TimoGlastra TimoGlastra linked an issue Mar 7, 2023 that may be closed by this pull request
Test Askar in React Native and fix bugs that are encountered #112
Closed
@TimoGlastra TimoGlastra mentioned this pull request Mar 7, 2023
Closed
@TimoGlastra
fix: variable shadowing
afcf3e0 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra marked this pull request as ready for review March 7, 2023 13:18
@TimoGlastra TimoGlastra requested review from berendsliedrecht and genaris and removed request for berendsliedrecht March 7, 2023 13:19
This was referenced Mar 7, 2023
Merged
Merged
genaris
genaris previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple now it's done, but it was a long road to go!

As you mentioned in #108, I think it will still be nice to have its changes as it could still be possible to have an exception somewhere in the fetchNext.

@TimoGlastra TimoGlastra merged commit 1b5079e into openwallet-foundation:main Mar 7, 2023
jamshale pushed a commit to jamshale/askar that referenced this pull request Aug 18, 2024
@TimoGlastra
fix(js): several fixes for js wrapper (openwallet-foundation#111)
978842a 
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

@genaris genaris genaris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TimoGlastra @genaris @berendsliedrecht