-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace ursa lib with anoncreds-clsignatures-rs #226
chore: replace ursa lib with anoncreds-clsignatures-rs #226
Conversation
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
2bdf8b0
to
d1a7a3a
Compare
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Tagging @berendsliedrecht and @TimoGlastra for a review request. |
Note about this on the interface changes made to those using this library:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the JS part is fine. It misses the updates for React Native wrapper though. Not a common use case of course (and not sure if current issuance/revocation methods are properly working as we didn't test them systematically), so won't consider it as a blocker if not added to this PR.
Yes I should have mentioned that the RN wrappers were not updated. I assume they could be updated in a follow up PR to this. |
anoncreds-clsignatures 0.2 is out now with a few more updates, but I can add another PR for that. I think the revocation status list creation could be optimized so I'll look at that at the same time. |
@andrewwhitehead — what is the action here? Can we merge this, do we need to update to 0.2? Your note implies that we can do the 0.2 update later, but then you didn’t approve this. Thanks! |
Signed-off-by: Ariel Gentile <[email protected]>
Replaces
ursa
library withanoncreds-clsignatures-rs
.Removes some external dependencies which are now packaged with the updated library.
Resolves: #221
Resolves: #224
Many thanks to @andrewwhitehead for help on this.