fix: add support for legacy schema and cred def id #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Mar 11, 2023
| "CredentialDefinitionId" => &LEGACY_CRED_DEF_IDENTIFIER, | ||
| "SchemaId" => &LEGACY_SCHEMA_IDENTIFIER, | ||
| // TODO: we do not have correct validation for a revocation registry and definition id | ||
| "RevocationRegistryId" => &LEGACY_DID_IDENTIFIER, |
There was a problem hiding this comment.
Both are the same (rev reg id and rev reg def id). You can find regexes for this in identifiers.ts in afj
|
Already going to merge this, but would be good if you can make another pr with the changes for rev regs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@genaris this should fix your issue regarding the invalid cred_def / schema identifiers.
I was wondering if anyone knows a regex to match the revocation registry definition id and the revocation registry id.
Since the new identifier checker checks if it's just a uri, we will validate incorrect schemas with a version of
3for example. Curious to hear if we want to fix this or leave as-is.