Merge pull request #235 from andrewwhitehead/fix/ffi-rev-info

Remove tails path from FfiCredRevInfo
hyperledger · Aug 18, 2023 · bbd6b88 · bbd6b88
2 parents ddcc9be + c101592
commit bbd6b88
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 13 deletions.
diff --git a/include/libanoncreds.h b/include/libanoncreds.h
@@ -177,7 +177,6 @@ typedef struct FfiCredRevInfo {
   ObjectHandle reg_def;
   ObjectHandle reg_def_private;
   int64_t reg_idx;
-  FfiStr tails_path;
 } FfiCredRevInfo;
 
 typedef struct FfiCredentialEntry {

diff --git a/src/ffi/credential.rs b/src/ffi/credential.rs
@@ -18,11 +18,10 @@ use crate::services::{
 
 #[derive(Debug)]
 #[repr(C)]
-pub struct FfiCredRevInfo<'a> {
+pub struct FfiCredRevInfo {
     reg_def: ObjectHandle,
     reg_def_private: ObjectHandle,
     reg_idx: i64,
-    tails_path: FfiStr<'a>,
 }
 
 struct RevocationConfig {

diff --git a/wrappers/javascript/anoncreds-nodejs/test/bindings.test.ts b/wrappers/javascript/anoncreds-nodejs/test/bindings.test.ts
@@ -256,6 +256,7 @@ describe('bindings', () => {
       objectHandle: revocationRegistryDefinition,
       name: 'tails_location',
     })
+    expect(tailsPath).toBeTruthy()
 
     const timeCreateRevStatusList = 12
     const revocationStatusList = anoncreds.createRevocationStatusList({

diff --git a/wrappers/javascript/anoncreds-react-native/cpp/include/libanoncreds.h b/wrappers/javascript/anoncreds-react-native/cpp/include/libanoncreds.h
@@ -177,7 +177,6 @@ typedef struct FfiCredRevInfo {
   ObjectHandle reg_def;
   ObjectHandle reg_def_private;
   int64_t reg_idx;
-  FfiStr tails_path;
 } FfiCredRevInfo;
 
 typedef struct FfiCredentialEntry {

diff --git a/wrappers/javascript/anoncreds-react-native/cpp/turboModuleUtility.cpp b/wrappers/javascript/anoncreds-react-native/cpp/turboModuleUtility.cpp
@@ -521,12 +521,10 @@ FfiCredRevInfo jsiToValue(jsi::Runtime &rt, jsi::Object &options,
         rt, valueAsObject, "registryDefinitionPrivate");
     auto registryIndex =
         jsiToValue<int64_t>(rt, valueAsObject, "registryIndex");
-    auto tailsPath = jsiToValue<std::string>(rt, valueAsObject, "tailsPath");
 
     return FfiCredRevInfo{.reg_def = registryDefinition,
                           .reg_def_private = registryDefinitionPrivate,
-                          .reg_idx = registryIndex,
-                          .tails_path = tailsPath.c_str()};
+                          .reg_idx = registryIndex};
   }
 
   throw jsi::JSError(rt, errorPrefix + name + errorInfix +

diff --git a/wrappers/javascript/anoncreds-shared/src/api/RevocationRegistry.ts b/wrappers/javascript/anoncreds-shared/src/api/RevocationRegistry.ts
@@ -4,12 +4,6 @@ import type { RevocationRegistryDefinition } from './RevocationRegistryDefinitio
 import { AnoncredsObject } from '../AnoncredsObject'
 import { anoncreds } from '../register'
 
-export type RevokeCredentialOptions = {
-  revocationRegistryDefinition: RevocationRegistryDefinition
-  credentialRevocationIndex: number
-  tailsPath: string
-}
-
 export type UpdateRevocationRegistryOptions = {
   revocationRegistryDefinition: RevocationRegistryDefinition
   issued: number[]