Add support for soroban auth framework 🚀 #1748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaheldinsoliman
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
Signed-off-by: salaheldinsoliman <[email protected]>
salaheldinsoliman
force-pushed
the
feat/soroban_auth_framework
branch
from
c383464 to
5820c61
Compare
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support Soroban authorization framework:
Here are some keynotes to consider:
1- Unlike Solidity, Soroban performs its auth checks using the host. For instance, Soroban doesn't have the construct of
if msg.sender == addr, however this check is done via a host functionaddr.require_auth.2- Another function was added
authAsCurrContract. This is needed for deeper calls. To understand this, take a look at https://github.com/stellar/soroban-examples/tree/main/deep_contract_auth.What I have done here actually is test the auth framework using the above provided example of nested calls.