Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #99

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Update README #99

merged 10 commits into from
Nov 1, 2024

Conversation

jimthematrix
Copy link
Contributor

No description provided.

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Really enjoyed reading through it and how you progressively built each solution up 😃

A few comments and typos

README.md Outdated Show resolved Hide resolved
@@ -41,44 +57,124 @@ The statements in the proof include:
- the sum of the input values match the sum of output values
- the hashes in the input and output match the hash(value, salt, owner public key) formula
- the sender possesses the private BabyJubjub key, whose public key is part of the pre-image of the input commitment hashes
- the encrypted value in the input is derived from the receiver's UTXO value and encrypted with a shared secret using the ECDH protocol between the sender and receiver (this guarantees data availability for the receiver)
- the encrypted values in the transaction are derived from the receiver's UTXO value and encrypted with a shared secret using the ECDH protocol between a random private key and the receiver (this guarantees data availability for the receiver, because the public key for the random private key used by the sender is published in the transaction)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd to say random private key it gives a lack of trust - isn't it just the private key of the sender?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in fact a one-time use private key that's generated for that transaction only, instead of using the sender's private key. The receiver only needs to know the public key, which is included in the transaction and event.

Copy link
Contributor

@EnriqueL8 EnriqueL8 Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah okay so maybe specifying that is better than random, gives more context

so one time use private key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remember to do that in the next PR

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to show the sparse merkle tree for KYC in a diagram in a follow up PR :)

jimthematrix and others added 5 commits November 1, 2024 10:33
Co-authored-by: Enrique Lacal <[email protected]>
Signed-off-by: jimthematrix <[email protected]>
Co-authored-by: Enrique Lacal <[email protected]>
Signed-off-by: jimthematrix <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This comment remaining #99 (comment) up to you on this

@jimthematrix jimthematrix merged commit 59045b4 into main Nov 1, 2024
6 checks passed
@jimthematrix jimthematrix deleted the readme branch November 1, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants