Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit pod naming design #105

Closed
jt-nti opened this issue Feb 27, 2024 · 1 comment · Fixed by #112
Closed

Revisit pod naming design #105

jt-nti opened this issue Feb 27, 2024 · 1 comment · Fixed by #112
Labels
design Design discussions
Milestone

Comments

@jt-nti
Copy link
Member

jt-nti commented Feb 27, 2024

There are limits on pod names which led to the current human unfriendly names in #16. While there are labels and annotations to help manage the chaincode pods, it would be good to improve the pod names as well.

@jt-nti
Copy link
Member Author

jt-nti commented Mar 12, 2024

Hi @davidfdr, I've been thinking about your suggestion on discord:

In my opinion, the pod name needs to have the chaincode package name. The package hash is already a SHA hash, so, may we just use , removing the ":" or, just add the chaincode name plus some hash concatenated (Need to check the RFC naming convention ).

I think we can get something like that to work. I'm currently thinking something along the lines of...

<prefix>-<chaincode_label>-<chaincode_run_hash>

Where <prefix> could be configured using an environment variable instead of always being cc. This would provide a way to distinguish between peers in the same namespace but without hitting problems trying to make the peer address work in a pod name.

<chaincode_run_hash> would be similar to the current hash but shorter, i.e. not the hash from the chaincode ID. Possibly a hash of the chaincode.json file that the run binary gets?

Hopefully that would leave enough space for enough of the <chaincode_label> to be useful, although it would need to be truncated and stripped of any invalid pod name characters.

jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue Apr 22, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 1, 2024
jt-nti added a commit to jt-nti/fabric-builder-k8s that referenced this issue May 3, 2024
jt-nti added a commit that referenced this issue May 3, 2024
Resolves #105

Signed-off-by: James Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design discussions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant