Add transaction to delete assets recursively #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvenzi
added a commit
that referenced
this pull request
Sep 11, 2023
… of the following contributors: Bruno Andreghetti, Andre Macedo, Marcos Sarres, Lucas Campelo, João Assis and Arthur Paiva to this repo subject to the Developer Certificate of Origin (DCO), Version 1.1. f385056 Merge pull request #25 from GoLedgerDev/develop 9cd9916 Merge pull request #24 from GoLedgerDev/feature/events ddc8d67 ✅ Update getTx test 790c286 💡 Fix comment error 3f8bad1 ✨ Add readOnly custom events 1bb8b4f ✅ Add event fetch tests 57fd535 ✅ Update getTx test 15dc23b 🐛 Change method of executeEvent tx edc9380 📝 Update comments 1000d70 ✨ Allow access to stub on custom events 14b866b ✨ Add base log to events b78448b ✨ Improve error handling on custom function 6dbdf7d ✨ Execute event tx on list 2cba60e ✨ Custom events 4b77ae2 ✨ Event funcionality 3872a70 Merge pull request #23 from GoLedgerDev/refactor/several-fixes-changes 799f2b8 💡 Correct Get description comment 6510e45 ✨ AssetType filtering on referrers e9f2ad4 ✨ Implement History in the manner of Search 09b1abc Merge pull request #22 from GoLedgerDev/develop 5e4204e Merge pull request #21 from GoLedgerDev/fix/custom-map-datatypes f6e2d9e ✨ GetMany function on assets 6e34e77 🐛 Verify if key is not nil on NewKey 4068477 ✨ Cross validate @key and @assetType on NewKey 8a1a138 🐛 Fix bug on getRecursive to consider custom map datatypes d9d5bba Merge pull request #20 from GoLedgerDev/dynamic-on-schema fb72af7 ✅ Update getSchema test 35b95bd ✨ Add dynamic info on schema 91eefe1 Merge pull request #17 from GoLedgerDev/develop f9c62d4 Merge pull request #16 from GoLedgerDev/dynamic-assetType 0212e65 ✅ Add new update asset type tests fdab745 💡 Update comments on updateType tx 71039f8 💡 Remove comments d75f54f ✨ Allow references to types being created on the same request 0b946b2 ✅ Add updateType testes b09b3a6 ✅ Create more tests and correct leftovers from existing ones 6cdaa3b ✅ Add more tests d3ec093 ✅ Update getTx and getSchema tests a556232 ✅ Create more tests for createAssetType b379368 ✅ Create createAssetType test 3416542 🔥 Remove unnecessary code e579c41 🐛 Fix time conversion ae32821 ✨ Avoid updating asset list when list in not outdated f3222f2 ✨ Update assetlist on Run 3c6cce0 👔 Dont remove assets on type deletion ee944f1 👔 Dont allow the creation of isKey prop on update b096400 ♻️ Simplify checkEmptyAssets 684fe23 🐛 Fix defaultValues initialization while updating assetType fb34355 🐛 Fix typo on switch 52dc17c 👔 Avoid isKey and datatype update on prop 11cab8a 🔥 Remove unused function e8b2e98 ♻️ Simplify ReplaceAssetType function 8e46ea8 ♻️ Remove setEvent function from assetListFuncs f6fa25c ⚡ Avoid updating asset type list when none valid is created b74c20f 🔥 Consolidate asset admins configs into one 3e766e6 ✨ Store updated list on update and delete transactions 96596f4 🐛 Change way list restoration handles deleted assets 5919f1c 🐛 Allow updates on dynamic types 595ffd1 🐛 Fix dymanic verification while getting restored list c102bed ✨ Set event notification on update and delete of asset type list 8660b11 ✨ Eliminate deleted types from restored list 2f44271 🐛 Allow any org to call loadAssetTypeList e890aa4 🐛 Handle when no readers/writers prop on restore 0e76e16 🐛 Fix readers access on conversion fb1e823 🐛 Fix writers prop conversion 2cb77e2 ✨ Improve asset list restore from blockchain fab27ae 🐛 Fix list from array conversion 9d49630 🐛 Improve erros and change assetTypeListData datatype 449f945 ✨ Update store and restore asset type list to use helper methods 9acbfa7 ✨ Dynamic information on AssetType d14e12e ✨ Create map conversion functions to assetType and assetProp 6490664 🐛 Fix AssetType list data writers 61bc1a9 🐛 Open readers for assetTypeListData 4cc9885 ✨ Implement asset type list loading from blochchain f36d427 ✨ Implement restore AssetList from blockchain 29bc95c 🐛 Create list asset when inexistant 7cbc6e1 ✨ Store asset list on blockchain 975f10e ✨ Fallback for asset type list in case of fail on update d8fa5ad ✨ Improve updateAssetType response 881f861 ♻️ Reorganize Dynamic AssetType functions 2111672 🐛 Modify callers initialization for dynamic AssetTypes txs 8449da7 ✨ Implement Dynamic AssetTypes configuration data 05e26d5 🐛 Avoid initialization of empty readers/writers array aaa4134 ✨ Handle not required to required prop update on dynamic types d661e55 ✨ Handle new required props while updating types 9766b1e ✨ Improve validations for prop deletion on update 3dff021 ✨ Update props on type update dd090b5 ✨ Delete props on update bcf3393 ✨ Add new props on update 877a3f2 🐛 Modify way types are updated 5c89019 ✨ Initial updateAssetType implementation 453c82e ✨ Check for references when deleting asset type fbd31b6 🐛 Fix dataType verification bug 4158cf6 🐛 Fix bug while creating assetType with non primiteve datatype 8b3536d ✨ Improve deleteAssetType response ec505e9 🐛 fix query creation bug 54afda1 ✨ Delete checks on dynamic asset Types cf96e0c ✨ Initial deleteAssetType implementation 7947d9a ✨ Datatype validation on dynamic asset type creation 0c34914 ✨ Default Value verification when creating dynamic asset type 4ccd9bb 🐛 Allow for null readers array d49bbc1 ✨ Type verification on asset type building a276b9f ✨ Verify Asset Type existance on creation d625387 ✨ Allow list of ATs on dynamic creation a281c6a 🐛 Fix writers prop access e3f23a3 🚧 Initial createAssetType implementation 128f971 Merge pull request #15 from GoLedgerDev/develop 3b28d3c Fix test by adding @object to expected response af26e63 Fix recursive search for @object properties 69d654a SplitCompositeKey wrapper aa2c482 Merge pull request #14 from GoLedgerDev/develop 85f08d7 Update README.md a183b57 Merge pull request #13 from GoLedgerDev/develop 9c85233 Merge pull request #12 from GoLedgerDev/feature/obj-asset-dtype e823e9a Fix tests with new @object property 885a6a2 Increment testing for @object data type cd5d90d Add @object datatype to getDataTypes test 1c24696 Add generic object datatype d1e657c Merge pull request #11 from GoLedgerDev/develop 064ecfc Merge pull request #10 from GoLedgerDev/hotfix/getRecursive f6ba4fd Remove unwanted logs 093c5af Fix getRecursive for list of references 4096d35 Fix getRecursive when 2+ references of the same asset are subassets e0e28c5 Merge pull request #8 from GoLedgerDev/hotfix/updateRecursive a404176 Fix recursive update with correct object assembly 73b08bd Merge pull request #7 from GoLedgerDev/hotfix/updateRecursive 653b6d7 Remove wrong verification of asset properties 3d6f281 Merge pull request #6 from GoLedgerDev/develop 731d925 Merge pull request #5 from GoLedgerDev/feature/updateRecursive eb0c061 Remove print 5c0919a Implement experimental updateRecursive bc12b84 Merge pull request #4 from GoLedgerDev/develop fc6b95f Implement CommittedInLedger function a78566d Inject tx timestamp in assets 6d68838 Refactor Search tx bb679fd Clean up Search tx 07e1fe7 Merge pull request #3 from GoLedgerDev/refactor/fix-comment 66d5391 Fix GetMap function comment 3c15cd7 Improve GenerateKey type flexibility with subAsset keys ee9310f Verify duplicate arg tag in tx StartUpCheck 6ce6339 Implement Referrers method and add correponding automated test 528513e Improve slice compatibility in validateProp 2029897 Update issue templates 9fb32d9 Update header version 72b577c Internalize shimtest since fabric does not support it anymore b84a9e2 Add GetCommitted methods and automated tests 91a406f Make error message more informative when user tries to get keyless asset 240541a Update dependencies c5f622e Add key.Delete and key.DeleteCascade methods 2f95493 Fix header test a618248 Remove more old tests ec2cbf8 Make DeleteCascade respect writer permissions 5747200 Remove warnings and old tests ade0be4 Unify test package and expand tests 25c5ffe Finish automated tests for basic features of the transaction package 6235356 Improve transactions package tests 1e40dd6 Improve transactions package tests 6d22b9e Finish tryout_test.go 8bea7e4 WIP Greatly improve test coverage 458b1af Create go.yml 3a7384a Fix header version 861bede Add LICENSE and NOTICE files 537a85c Add ccToolsVersion to header 34831c3 Improve history data 0a8386d fix all custom data types pointing to the same data types 78403d9 Add warning in PutRecursive and DeleteCascade method 3ee98a1 Merge pull request #2 from GoLedgerDev/fix/deleteRecursive 50fa7c6 Move IsReferenced check to avoid cyclic reference error in DeleteCascade 1afee00 Improve deleteRecursive 49a973d Refator asset.Delete method and improve automated test a3bbe4a add testes to delete asset and delete asset recursively 47f55c1 Improve error message f38e6d9 Make read-only txs mandatory to avoid goinitus breakage 2a2fee3 use slice pointers instead of returning it between recursive calls a0720ca Add JSON method to assets.Asset and assets.Key types 1b86858 Make DeleteRecursive an optional mode of DeleteAsset instead of a separate tx efc1e50 Fix deleteRecursive using global slice f8c713b Validate tx arg datatypes in StartupCheck 73b8487 Make GetHeader a standard tx 409dda2 Make GetRecursive format-independant (avoid breaking after cc update) 6818c08 Implement StubWrapper b5d7942 Make getHistory timeTarget be limited to past targets 2485cac Remove legacy support for Validate and KeyString datatype functions f9244fa Make txArgs use "->" when referencing asset types cdcca8f Make standard txs optional (except for a few meta txs) 33c1e25 Implement target time in getHistory tx 97b54f9 Make assets.Update return errors.ICCError 6dddefe Change cleanUp call position 83f397f Change update behavior to allow asset fixing after cc upgrade 8522e95 Fix getRecursive infinite recursion check 33c162f Fix error checking in putRecursive function 4741c31 Remove nil entries in tx arguments f4b90d7 Add simple package overview dc74e1a Mark deprecation properly 6799888 Merge pull request #1 from GoLedgerDev/feature/deleteRecursive 3537da6 Add deleteRecursive transaction 9013535 Finish docs review ccb3278 Begin docs review a77904d change struct comment style 2547631 crude docs on getArgs method 2701b12 docs argument struct 3c070cd adds comments to remaining error method 7dbeb63 adds docs to internal function validateProp adfb942 adds additional info to update function 54a113f adds disclaimer to SetProp function 5744eb9 change sentence ordering for better understanding e2a2fdc adds put internal function docs b882785 adds key docs d3d6163 complement generateKey docs e7b068f adds docs for existsInLedger a777444 adds delete method docs 1a44d54 adds DataType struct docs 33d96b8 adds clean method docs 1fe4d13 adds private checkWriters functions docs b1ed75b adds assetType struct docs 52befe7 assetprop docs a32c547 asset.go 913f0a6 comments on ICCError interface 4533047 fix typo 294e88c Fix Typo 0fe63b2 remove logs 194da5b fix recursiveget looping between assets a5d8158 Fix conversion to map[string]interface{} in putRecursive b5c056e Fix put recursive 8bfb21b Implement recursive put functions 37b021b Fix typo 6655bb8 Add @object type of argument for receiving generic object e8dea62 Add "resolve" argument to readAsset and search txs 2ea69d5 Fix automated tests c8e6289 Remove Document-related transactions from standard txs list a246b2e Fix nil private data hash bug aeceea2 Make standard txs part of cc-tools 11b7aa4 Expand automated tests ee276db Finish GetRecursive implementation b8b954e Add GetRecursive function to assets.Asset and assets.Key 5e323a3 Begin to expand automated tests using shim.MockStub 24702cf Begin to write transactions package automated tests f15fbf2 A lot more automated tests and minor improvements 56fd429 Add most basic automated tests c450bdd Begin to write automated tests ae75a73 Trim keys to just @assetType and @key properties e558282 Change tx.Args to ArgList type which is []Argument instead of map 307fb47 Add GetProp to key type 1ca2af9 Add quality of life methods for existing types 3e6e604 Add another panic safeguard 04dcad1 Add more safeguards to avoid panic a1222b9 Fix panic involving nil values d46cc09 Add clean internal function to remove nil entries in assets before put 1b215ed Eliminate the need for passing @assetType where it can be implied 11c6c0a Change asset arg behavior to match goinitus's 4268b78 Fix retrocompatibility bug in custom datatypes b37dd0d Fix '->' marker logic bug 5c24873 Add '->' marker logic to indicate subasset reference datatypes 7e2cff9 Invert DropDownValues structure 27c8cab Improve DefaultValue-related StartupCheck routine 3bd03d4 Add DefaultValue json tag e9111aa Add DropDownValues attribute to DataType ccf7c25 Add default value support 182d56c Fix datetime bug from v0.4.0-rc1 7d17eff Add integer primitive data type a69cfd1 Change private asset existence check to GetPrivateDataHash 0100caa Fix bug in duplicate check 6f9d2a9 Unify KeyString and Validate datatype functions as Parse 2ef6027 Add duplicate tag and label verification c3096a8 Add "description" field to asset property 85e6d44 Fix bug in private asset list 8400ba2 Require regexp specification when using it in Writers and Callers lists 2ee72df Improve error message for "cannot write to property" 8f08ec7 Fix update bug 033edf0 Remove global asset writers 70ba8d8 Add AcceptedFormats and Description to custom data types 736294c Fix GenerateKey bug 2ddb148 Rename DataType.String to DataType.KeyString c3c3757 Implement dynamic data types 0867443 WIP Implement dynamic data types 1b2e873 Add IsPrivate method to the AssetType class 494770e Unify protobuf package being used edc2c86 Make many validations and procedures internal to minimize interface 71c9373 Refactor assets package and tidy dependency versions 816118e Refactor CheckWriters asset method 008099d Implement PutNew function for Asset type e999ad5 Get rid of template-cc/errorhandler dependency 1422107 Fix getTx injection 4bd58e9 Export transactions.Argument type e8ff1df Add transactions package 66b595d Add assets package f5c8b24 Initial commit Signed-off-by: Samuel Venzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.