Feature/subscription engine #813

iceseer · 2021-02-15T18:07:41Z

Linked issue

Closes #831

Description of the Change

Subscription engine implementation.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Signed-off-by: iceseer <[email protected]>

Signed-off-by: iceseer <[email protected]> # Conflicts: # irohad/main/application.cpp

Signed-off-by: iceseer <[email protected]>

irohad/subscription/common.hpp

Signed-off-by: iceseer <[email protected]>

irohad/subscription/thread_handler.hpp

irohad/subscription/common.hpp

irohad/subscription/dispatcher.hpp

irohad/subscription/thread_handler.hpp

libs/common/compile-time_murmur2.hpp

irohad/subscription/subscriber_impl.hpp

irohad/subscription/subscription_engine.hpp

irohad/subscription/common.hpp

Signed-off-by: iceseer <[email protected]>

kuvaldini · 2021-03-10T11:53:42Z

irohad/subscription/dispatcher.hpp

+    template <typename F>
+    void add(Tid tid, F &&f) {
+      assert(tid < kHandlersCount);
+      handlers_[tid].add(std::forward<F>(f));
+    }


Let's reuse neibor function

Suggested change

template <typename F>

void add(Tid tid, F &&f) {

assert(tid < kHandlersCount);

handlers_[tid].add(std::forward<F>(f));

}

template <typename F>

void add(Tid tid, F &&f) {

addDelayed(tid,{0},std::forward<F>(f));

}

kuvaldini · 2021-03-10T12:00:42Z

irohad/subscription/dispatcher.hpp

+    }
+
+    template <typename F>
+    void addDelayed(Tid tid, std::chrono::microseconds timeout, F &&f) {


Если читать код как прозу - тогда "диспетчер добавь отложенное" звучит не обчень понятно. что добавить и куда?

Если обратится в boost::asio они говорят io_context::run_after() и тут понятно что это отложенный запуск задачи-функции.

Это вопрос конечно на функциональность не влияющий – но если мы будем писать понятный код потомки нас будут благодарить. и сами себя

* subscription: utils Signed-off-by: iceseer <[email protected]> * threaded handler Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * dispatcher Signed-off-by: iceseer <[email protected]> * dispatcher Signed-off-by: iceseer <[email protected]> * subscription engine Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * compile-time murmur2 Signed-off-by: iceseer <[email protected]> * engine refactoring Signed-off-by: iceseer <[email protected]> * dispatcher in engine Signed-off-by: iceseer <[email protected]> * TID chained Signed-off-by: iceseer <[email protected]> * dispatcher checks Signed-off-by: iceseer <[email protected]> * engine multithreaded Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * manager Signed-off-by: iceseer <[email protected]> * compiled Signed-off-by: iceseer <[email protected]> * compiled Signed-off-by: iceseer <[email protected]> * work Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * comments Signed-off-by: iceseer <[email protected]> * test Signed-off-by: iceseer <[email protected]> * rollback test Signed-off-by: iceseer <[email protected]> # Conflicts: # irohad/main/application.cpp * move args Signed-off-by: iceseer <[email protected]> * thread safe Signed-off-by: iceseer <[email protected]> * fixup! Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * rw object holder Signed-off-by: iceseer <[email protected]> * rename Signed-off-by: iceseer <[email protected]> * SE sync call Signed-off-by: iceseer <[email protected]> * issue fixes Signed-off-by: iceseer <[email protected]> * revert sync call Signed-off-by: iceseer <[email protected]> Signed-off-by: Alexander Lednev <[email protected]>

* subscription: utils Signed-off-by: iceseer <[email protected]> * threaded handler Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * threaded handler queue Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * dispatcher Signed-off-by: iceseer <[email protected]> * dispatcher Signed-off-by: iceseer <[email protected]> * subscription engine Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * compile-time murmur2 Signed-off-by: iceseer <[email protected]> * engine refactoring Signed-off-by: iceseer <[email protected]> * dispatcher in engine Signed-off-by: iceseer <[email protected]> * TID chained Signed-off-by: iceseer <[email protected]> * dispatcher checks Signed-off-by: iceseer <[email protected]> * engine multithreaded Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * manager Signed-off-by: iceseer <[email protected]> * compiled Signed-off-by: iceseer <[email protected]> * compiled Signed-off-by: iceseer <[email protected]> * work Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * comments Signed-off-by: iceseer <[email protected]> * test Signed-off-by: iceseer <[email protected]> * rollback test Signed-off-by: iceseer <[email protected]> # Conflicts: # irohad/main/application.cpp * move args Signed-off-by: iceseer <[email protected]> * thread safe Signed-off-by: iceseer <[email protected]> * fixup! Signed-off-by: iceseer <[email protected]> * refactoring Signed-off-by: iceseer <[email protected]> * format Signed-off-by: iceseer <[email protected]> * rw object holder Signed-off-by: iceseer <[email protected]> * rename Signed-off-by: iceseer <[email protected]> * SE sync call Signed-off-by: iceseer <[email protected]> * issue fixes Signed-off-by: iceseer <[email protected]> * revert sync call Signed-off-by: iceseer <[email protected]> Signed-off-by: Alexander Lednev <[email protected]> Signed-off-by: G.Bazior <[email protected]>

iceseer added 27 commits February 15, 2021 21:14

subscription: utils

0ced3f7

Signed-off-by: iceseer <[email protected]>

threaded handler

12a11f3

Signed-off-by: iceseer <[email protected]>

threaded handler queue

92510d9

Signed-off-by: iceseer <[email protected]>

threaded handler queue

57aa784

Signed-off-by: iceseer <[email protected]>

threaded handler queue

ec64389

Signed-off-by: iceseer <[email protected]>

refactoring

fee6c08

Signed-off-by: iceseer <[email protected]>

dispatcher

1c4572e

Signed-off-by: iceseer <[email protected]>

dispatcher

882f63c

Signed-off-by: iceseer <[email protected]>

subscription engine

385f9bd

Signed-off-by: iceseer <[email protected]>

format

bd803be

Signed-off-by: iceseer <[email protected]>

compile-time murmur2

8cd691e

Signed-off-by: iceseer <[email protected]>

engine refactoring

4115bb4

Signed-off-by: iceseer <[email protected]>

dispatcher in engine

6fc866e

Signed-off-by: iceseer <[email protected]>

TID chained

7084a4f

Signed-off-by: iceseer <[email protected]>

dispatcher checks

86ee128

Signed-off-by: iceseer <[email protected]>

engine multithreaded

c5424da

Signed-off-by: iceseer <[email protected]>

format

b3a1dc6

Signed-off-by: iceseer <[email protected]>

format

7730b5e

Signed-off-by: iceseer <[email protected]>

manager

4edaf61

Signed-off-by: iceseer <[email protected]>

compiled

7678049

Signed-off-by: iceseer <[email protected]>

compiled

f5bb87e

Signed-off-by: iceseer <[email protected]>

work

0a273a7

Signed-off-by: iceseer <[email protected]>

refactoring

96ee1ac

Signed-off-by: iceseer <[email protected]>

format

4dbd07b

Signed-off-by: iceseer <[email protected]>

comments

96f21ed

Signed-off-by: iceseer <[email protected]>

test

1f80c31

Signed-off-by: iceseer <[email protected]>

rollback test

aff5567

Signed-off-by: iceseer <[email protected]> # Conflicts: # irohad/main/application.cpp

iceseer force-pushed the test/subscription_engine branch from c773d5f to aff5567 Compare February 15, 2021 18:16

iceseer requested a review from kamilsa February 15, 2021 18:18

move args

ffe1911

Signed-off-by: iceseer <[email protected]>

iceseer added 2 commits February 15, 2021 22:38

thread safe

0cc7d83

Signed-off-by: iceseer <[email protected]>

fixup!

796258b

Signed-off-by: iceseer <[email protected]>

kamilsa mentioned this pull request Feb 19, 2021

Update subscription engine qdrvm/kagome#680

Open

iceseer added 4 commits February 23, 2021 21:21

refactoring

8eaecfb

Signed-off-by: iceseer <[email protected]>

format

ab87813

Signed-off-by: iceseer <[email protected]>

rw object holder

e8087d6

Signed-off-by: iceseer <[email protected]>

rename

3fe8e1a

Signed-off-by: iceseer <[email protected]>

kuvaldini reviewed Mar 9, 2021

View reviewed changes

SE sync call

d767905

Signed-off-by: iceseer <[email protected]>

kamilsa approved these changes Mar 9, 2021

View reviewed changes

irohad/subscription/thread_handler.hpp Outdated Show resolved Hide resolved

kuvaldini suggested changes Mar 10, 2021

View reviewed changes

kuvaldini reviewed Mar 10, 2021

View reviewed changes

irohad/subscription/subscriber_impl.hpp Show resolved Hide resolved

irohad/subscription/subscription_engine.hpp Show resolved Hide resolved

irohad/subscription/subscription_engine.hpp Outdated Show resolved Hide resolved

kuvaldini reviewed Mar 10, 2021

View reviewed changes

irohad/subscription/common.hpp Show resolved Hide resolved

iceseer added 2 commits March 10, 2021 15:49

issue fixes

3a92101

Signed-off-by: iceseer <[email protected]>

revert sync call

fb48bf4

Signed-off-by: iceseer <[email protected]>

iceseer force-pushed the test/subscription_engine branch from 994a4d9 to fb48bf4 Compare March 10, 2021 12:49

Merge branch 'support/1.2.x' into test/subscription_engine

199b435

iceseer requested a review from kuvaldini March 10, 2021 13:15

kuvaldini reviewed Mar 10, 2021

View reviewed changes

kuvaldini approved these changes Mar 10, 2021

View reviewed changes

iceseer merged commit 6a558b5 into hyperledger-iroha:support/1.2.x Mar 10, 2021

iceseer deleted the test/subscription_engine branch March 10, 2021 13:58

This was referenced Jul 12, 2021

CMAKE INTERPROCEDURAL OPTIMIZATION #1146

Closed

support/1.2.x #1147

Closed

kuvaldini mentioned this pull request Jul 30, 2021

v1.3: support/1.2.x with fixed DCO to main #1302

Closed

kamilsa mentioned this pull request Sep 2, 2021

1.3-rc release candidate #1298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/subscription engine #813

Feature/subscription engine #813

iceseer commented Feb 15, 2021 •

edited by kamilsa

Loading

kuvaldini Mar 10, 2021

kuvaldini Mar 10, 2021

Feature/subscription engine #813

Feature/subscription engine #813

Conversation

iceseer commented Feb 15, 2021 • edited by kamilsa Loading

Linked issue

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

kuvaldini Mar 10, 2021

Choose a reason for hiding this comment

kuvaldini Mar 10, 2021

Choose a reason for hiding this comment

iceseer commented Feb 15, 2021 •

edited by kamilsa

Loading