-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: mkdir -r
with store path, not lock path
#3908
Merged
0x009922
merged 4 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:fix-kura-lock-mkdir
Sep 21, 2023
Merged
[fix]: mkdir -r
with store path, not lock path
#3908
0x009922
merged 4 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:fix-kura-lock-mkdir
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
commented
Sep 21, 2023
DCNick3
previously approved these changes
Sep 21, 2023
Pull Request Test Coverage Report for Build 6259473002
💛 - Coveralls |
pesterev
reviewed
Sep 21, 2023
Signed-off-by: Dmitry Balashov <[email protected]>
pesterev
previously approved these changes
Sep 21, 2023
DCNick3
previously approved these changes
Sep 21, 2023
Signed-off-by: Dmitry Balashov <[email protected]>
DCNick3
approved these changes
Sep 21, 2023
pesterev
approved these changes
Sep 21, 2023
6r1d
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [fix]: `mkdir -r` with store path, not lock path Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: use `store_path` in the err Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: `&` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: apply lint Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
6r1d
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [fix]: `mkdir -r` with store path, not lock path Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: use `store_path` in the err Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: `&` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: apply lint Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
mversic
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [fix]: `mkdir -r` with store path, not lock path Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: use `store_path` in the err Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: `&` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: apply lint Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBH, I am lazy to prepare a proper reproduction of the bug. In my case, Iroha repeatedly failed to start, complaining about existence of the lock file all the time. After all, it turned out that
./storage/kura.lock
, created by Iroha, is a directory, not a file.This PR makes variables naming clearer, and passes actual block-store path into
mkdir -r
, not the path of the lockfile.