Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] #3622: Use cargo manifest lints instead of unmaintained cargo-lints #3904

Merged

Commits on Sep 20, 2023

  1. [ci] hyperledger-iroha#3622: Use cargo manifest lints instead of unma…

    …intained cargo-lints
    
    Since the implementation of rust-lang/rfcs#3389, it is now possible to specify workspace-level lints for rustc and clippy. This PR updates the cargo configuration and CI to use this new feature instead of cargo-lints.
    
    Note that it was only stabilized in `nightly-2023-09-10`. Using it with out current toolchain requires either a -Zlints flag or a modification to `.cargo/config.toml`:
    
    ```
    [unstable]
    lints = true
    ```
    
    Note that unlike the original suggestion in hyperledger-iroha#3622, this doesn't make the lints crate level, but merely replaces a clunky unmaintained tool with a standard solution for configuring lints.
    
    In particular this PR:
    - Removes old lints.toml configuration files for cargo-lints
    - Adds [lint] tables to Cargo.toml of the root and wasm workspaces. The lints are duplicated between the two
    - Replaces `cargo lints clippy` invocations with `cargo clippy -Zlints` in CI scripts
    - Silences/fixes some new lints that popped up due to differences in how between `cargo lints` and workspaces
    - Does a drive-by fix to iroha_genesis: it now too shares cargo metadata as do other crates
    
    Signed-off-by: Nikita Strygin <[email protected]>
    DCNick3 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e6667c7 View commit details
    Browse the repository at this point in the history