[feature] #1619: Introduce event-based triggers #1874

appetrosyan · 2022-02-07T05:17:11Z

Description of the Change

Add TriggerSet and carry trigger recommendations through the lifecycle of a block.

TriggerSet is stored in WSV.

Issue

Closes #1619
Closes #1859
Related to #1771

Benefits

Event triggers

Possible Drawbacks

Prototype implementation, so both UX and reliability are untested.

Event processing is quadratic.

Opens #1889
Opens #1890
Opens #1891
Opens #1892

codecov · 2022-02-07T05:47:47Z

Codecov Report

Merging #1874 (d00ceeb) into iroha2-dev (7f51a10) will decrease coverage by 0.77%.
The diff coverage is 46.12%.

@@              Coverage Diff               @@
##           iroha2-dev    #1874      +/-   ##
==============================================
- Coverage       79.02%   78.24%   -0.78%     
==============================================
  Files             163      164       +1     
  Lines           22243    22528     +285     
==============================================
+ Hits            17577    17627      +50     
- Misses           4666     4901     +235

Impacted Files	Coverage Δ
core/src/lib.rs	`65.29% <ø> (ø)`
core/src/smartcontracts/isi/asset.rs	`68.12% <ø> (ø)`
core/src/smartcontracts/isi/mod.rs	`74.32% <ø> (ø)`
core/src/tx.rs	`97.87% <ø> (ø)`
data_model/src/transaction.rs	`66.89% <ø> (ø)`
data_model/src/lib.rs	`49.42% <5.06%> (-19.47%)`	⬇️
core/src/triggers.rs	`8.33% <8.33%> (ø)`
data_model/src/events/data.rs	`35.46% <9.37%> (-12.76%)`	⬇️
data_model/src/events/mod.rs	`44.23% <25.00%> (-6.99%)`	⬇️
data_model/src/events/pipeline.rs	`90.07% <39.13%> (-9.93%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f51a10...d00ceeb. Read the comment docs.

core/src/wsv.rs

core/src/triggers.rs

appetrosyan · 2022-02-09T18:05:04Z

core/src/triggers.rs

+    /// Find all actions which match the current events.
+    pub fn actions_matching(&self, events: &[Event]) -> Vec<Action> {
+        let mut result = Vec::new();
+        for event in events {


This is quadratic, because DashMap is keyed in the trigger's name.

A solution would be to keep a few DashMaps with specialised filters, and custom logic. I'd leave that for a much later stage if possible.

core/src/block.rs

schema/src/lib.rs

core/src/wsv.rs

core/src/block.rs

s8sato · 2022-02-09T15:58:13Z

core/src/block.rs

@@ -312,11 +334,14 @@ impl ChainedBlock {
            .map(VersionedRejectedTransaction::hash)
            .collect::<MerkleTree<_>>()
            .root_hash();
+        let trigger_recommendations = self.trigger_recommendations;
+        // TODO: Validate trigger recommendations somehow?


I'm still under considering about how to validate the recommendations

I used to think that the technical accounts would be the solution. But the problem with them, is that you either don't attach a signature, store the private key on-chain or in a node, either of which defeats the point of validation.

This is left to #1891, right?

data_model/src/lib.rs

core/src/wsv.rs

s8sato · 2022-02-11T06:07:22Z

core/src/sumeragi/mod.rs

+        // TODO: This should properly process triggers
+        let trigger_recommendations = Vec::new();


From what this PR is suggesting,
wsv.triggers.recommendations works as a temporary store of the recommendations
which is based on events emitted by previous block application, right?
Then Sumeragi somehow can receive the recommendations from WSV

Exactly.

I'm wondering if there's more kinds of validation that we could do.

Could you create an issue for this TODO?

core/src/smartcontracts/isi/triggers.rs

core/src/triggers.rs

Signed-off-by: Aleksandr <[email protected]>

s8sato · 2022-02-18T07:42:50Z

core/src/block.rs

@@ -312,11 +334,14 @@ impl ChainedBlock {
            .map(VersionedRejectedTransaction::hash)
            .collect::<MerkleTree<_>>()
            .root_hash();
+        let trigger_recommendations = self.trigger_recommendations;
+        // TODO: Validate trigger recommendations somehow?


This is left to #1891, right?

s8sato · 2022-02-18T07:44:13Z

core/src/sumeragi/mod.rs

+        // TODO: This should properly process triggers
+        let trigger_recommendations = Vec::new();


Could you create an issue for this TODO?

appetrosyan self-assigned this Feb 7, 2022

appetrosyan requested review from mversic and s8sato February 7, 2022 05:17

github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 7, 2022

s8sato reviewed Feb 7, 2022

View reviewed changes

core/src/wsv.rs Show resolved Hide resolved

core/src/wsv.rs Outdated Show resolved Hide resolved

core/src/triggers.rs Outdated Show resolved Hide resolved

appetrosyan force-pushed the i2-trigger-events branch 2 times, most recently from be488e7 to 7c706f3 Compare February 7, 2022 18:22

s8sato reviewed Feb 8, 2022

View reviewed changes

core/src/triggers.rs Outdated Show resolved Hide resolved

core/src/triggers.rs Outdated Show resolved Hide resolved

appetrosyan force-pushed the i2-trigger-events branch 4 times, most recently from 60c5053 to 6c4fb22 Compare February 9, 2022 08:30

appetrosyan marked this pull request as ready for review February 9, 2022 08:36

appetrosyan requested a review from Arjentix as a code owner February 9, 2022 08:36

appetrosyan force-pushed the i2-trigger-events branch from 6c4fb22 to 81e7f51 Compare February 9, 2022 08:46

appetrosyan requested a review from s8sato February 9, 2022 10:07

appetrosyan commented Feb 9, 2022

View reviewed changes

mversic requested changes Feb 9, 2022

View reviewed changes

core/src/block.rs Outdated Show resolved Hide resolved

schema/src/lib.rs Outdated Show resolved Hide resolved

core/src/wsv.rs Outdated Show resolved Hide resolved

appetrosyan force-pushed the i2-trigger-events branch 2 times, most recently from 21cd85f to 38f5885 Compare February 10, 2022 08:12

appetrosyan marked this pull request as draft February 10, 2022 08:13

appetrosyan force-pushed the i2-trigger-events branch from 38f5885 to 8f1f57a Compare February 10, 2022 11:52

appetrosyan requested a review from mversic February 10, 2022 17:28

appetrosyan marked this pull request as ready for review February 10, 2022 17:28

appetrosyan force-pushed the i2-trigger-events branch from 8f1f57a to 849efbb Compare February 10, 2022 17:29

s8sato reviewed Feb 11, 2022

View reviewed changes

appetrosyan force-pushed the i2-trigger-events branch 2 times, most recently from 26686a7 to 8e33775 Compare February 11, 2022 07:02

mversic previously approved these changes Feb 11, 2022

View reviewed changes

core/src/smartcontracts/isi/triggers.rs Show resolved Hide resolved

core/src/triggers.rs Show resolved Hide resolved

core/src/triggers.rs Outdated Show resolved Hide resolved

core/src/triggers.rs Outdated Show resolved Hide resolved

appetrosyan requested a review from s8sato February 11, 2022 11:59

appetrosyan dismissed mversic’s stale review via bf9aa94 February 11, 2022 12:48

appetrosyan force-pushed the i2-trigger-events branch from 8e33775 to bf9aa94 Compare February 11, 2022 12:48

appetrosyan requested a review from mversic February 11, 2022 12:49

appetrosyan added the Enhancement New feature or request label Feb 12, 2022

appetrosyan force-pushed the i2-trigger-events branch 5 times, most recently from b684b60 to 86b0bc7 Compare February 17, 2022 14:10

appetrosyan added 3 commits February 17, 2022 18:11

Initial triggers implementation.

1b00bfe

Signed-off-by: Aleksandr <[email protected]>

Finalised EventTrigger implementation.

eba054c

Signed-off-by: Aleksandr <[email protected]>

Update data_model/src/lib.rs

d00ceeb

Signed-off-by: Aleksandr <[email protected]>

appetrosyan force-pushed the i2-trigger-events branch from 86b0bc7 to d00ceeb Compare February 17, 2022 14:12

mversic approved these changes Feb 17, 2022

View reviewed changes

s8sato approved these changes Feb 18, 2022

View reviewed changes

appetrosyan merged commit 2102df4 into hyperledger-iroha:iroha2-dev Feb 18, 2022

appetrosyan deleted the i2-trigger-events branch February 18, 2022 07:57

s8sato mentioned this pull request Feb 28, 2022

Store and validate events in the block #1771

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] #1619: Introduce event-based triggers #1874

[feature] #1619: Introduce event-based triggers #1874

appetrosyan commented Feb 7, 2022 •

edited

Loading

codecov bot commented Feb 7, 2022 •

edited

Loading

appetrosyan Feb 9, 2022

s8sato Feb 9, 2022

appetrosyan Feb 11, 2022

s8sato Feb 18, 2022

s8sato Feb 11, 2022 •

edited

Loading

appetrosyan Feb 11, 2022

s8sato Feb 18, 2022

s8sato Feb 18, 2022

s8sato Feb 18, 2022

		// TODO: This should properly process triggers
		let trigger_recommendations = Vec::new();

[feature] #1619: Introduce event-based triggers #1874

[feature] #1619: Introduce event-based triggers #1874

Conversation

appetrosyan commented Feb 7, 2022 • edited Loading

Description of the Change

Issue

Benefits

Possible Drawbacks

codecov bot commented Feb 7, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s8sato Feb 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

appetrosyan commented Feb 7, 2022 •

edited

Loading

codecov bot commented Feb 7, 2022 •

edited

Loading

s8sato Feb 11, 2022 •

edited

Loading