Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database connection string "pg_opt" and "database" config options should not be used both #907

Closed
kuvaldini opened this issue Mar 26, 2021 · 7 comments
Assignees
Labels
1.2.x Documentation Documentation changes iroha1 The legacy version of Iroha.

Comments

@kuvaldini
Copy link
Contributor

kuvaldini commented Mar 26, 2021

Please remove deprecated "pg_opt" from documentation.
Please check this is the only place.

изображение

Please also address #898

@LiraLemur Please consider to update example/config.sample and force Sphinx to load code sample from source-tree rather than copy contents to doc!

@LiraLemur
Copy link
Contributor

@kuvaldini the database too, right? The whole block? Or only the pg_opt?

@kuvaldini
Copy link
Contributor Author

"Database" is actual config, pgopt is old and deprecated.

@kuvaldini
Copy link
Contributor Author

@LiraLemur the best way is to load content from file example/config.sample'

@LiraLemur
Copy link
Contributor

@kuvaldini it's possible for the general example but there's also a description part anyway, which is simply impossible to load and it's important.

@kuvaldini
Copy link
Contributor Author

The file should be loaded, description should forget about pg_opt and use corresponding config keys under "database" config tree

@LiraLemur
Copy link
Contributor

I will make it load the file but we need to load it from the default branch which is main atm and there there is no metrics yet.
Just FYI @kuvaldini

Should be fine when it's merged into the main though

@kuvaldini
Copy link
Contributor Author

For branch support/1.2.x or any other please use config.sample exactly from the same branch. NOT from main. That is important.

This does not touch anything about metrics.

kuvaldini pushed a commit that referenced this issue Jun 15, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
kuvaldini pushed a commit that referenced this issue Jul 12, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
kuvaldini pushed a commit that referenced this issue Jul 14, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
kuvaldini pushed a commit that referenced this issue Jul 30, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
kuvaldini pushed a commit that referenced this issue Jul 30, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
kuvaldini pushed a commit that referenced this issue Aug 31, 2021
Add config example in docs always in sync with example/config.sample
Closes #907

Signed-off-by: Sara <[email protected]>
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.x Documentation Documentation changes iroha1 The legacy version of Iroha.
Projects
None yet
Development

No branches or pull requests

3 participants