-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database connection string "pg_opt" and "database" config options should not be used both #907
Comments
@kuvaldini the database too, right? The whole block? Or only the pg_opt? |
"Database" is actual config, pgopt is old and deprecated. |
@LiraLemur the best way is to load content from file example/config.sample' |
@kuvaldini it's possible for the general example but there's also a description part anyway, which is simply impossible to load and it's important. |
The file should be loaded, description should forget about pg_opt and use corresponding config keys under "database" config tree |
I will make it load the file but we need to load it from the default branch which is main atm and there there is no metrics yet. Should be fine when it's merged into the main though |
For branch This does not touch anything about metrics. |
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Add config example in docs always in sync with example/config.sample Closes #907 Signed-off-by: Sara <[email protected]>
Please remove deprecated "pg_opt" from documentation.
Please check this is the only place.
Please also address #898
@LiraLemur Please consider to update
example/config.sample
and force Sphinx to load code sample from source-tree rather than copy contents to doc!The text was updated successfully, but these errors were encountered: