This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kamilsa <[email protected]>
Signed-off-by: kamilsa <[email protected]>
Signed-off-by: kamilsa <[email protected]>
Signed-off-by: kamilsa <[email protected]>
Signed-off-by: kamilsa <[email protected]>
Another drawback is legacy for new networks :( |
Signed-off-by: kamilsa <[email protected]>
muratovv
approved these changes
Nov 30, 2018
@@ -27,3 +27,9 @@ message Block { | |||
Payload payload = 1; | |||
repeated Signature signatures = 2; | |||
} | |||
|
|||
message Block { | |||
oneof block_version { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe stay just version
here?
MBoldyrev
approved these changes
Nov 30, 2018
@@ -17,13 +17,14 @@ | |||
|
|||
#include <gflags/gflags.h> | |||
#include <rapidjson/istreamwrapper.h> | |||
#include <rapidjson/rapidjson.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest not removing this include, even if it works without it, because we directly create and use rapidjson::Document
in this file.
}, | ||
[&logger](const auto &error) { | ||
// should not get here | ||
logger->error("error while parsing serializing genesis block"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
logger->error("error while parsing serializing genesis block"); | |
logger->error("error while parsing serialized genesis block: " + error.error); |
Merged
kamilsa
added a commit
that referenced
this pull request
Dec 12, 2018
* Add oneof to the block Signed-off-by: kamilsa <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Before it was:
From now on it will be
Such changes would allow us to introduce Block_v2 and further versions, by simply adding them to oneof in Block message. Internally we will be able to recognize and manage different version of the blocks.
Benefits
Iroha will be able to process different versions of the blocks.
Possible Drawbacks
Format of genesis block is changing. So if you used old iroha, you will not be able to use old block store