This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Stateful Response Error Codes #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduced error codes to SQL Signed-off-by: Akvinikym <[email protected]> * Builds Signed-off-by: Akvinikym <[email protected]> * 4/16 commands Signed-off-by: Akvinikym <[email protected]> * 13/16 done Signed-off-by: Akvinikym <[email protected]> * Tests are finished Signed-off-by: Akvinikym <[email protected]> * Review issues Signed-off-by: Akvinikym <[email protected]> * Added a separated function for parsing SQL errors and making an error Signed-off-by: Akvinikym <[email protected]> * Review issues are addressed Signed-off-by: Akvinikym <[email protected]> * Added ToDos Signed-off-by: Akvinikym <[email protected]> * Some after-POW issues Signed-off-by: Akvinikym <[email protected]> * Error codes has good ordering Signed-off-by: Akvinikym <[email protected]> * More fixes Signed-off-by: Akvinikym <[email protected]> * Build fix Signed-off-by: Akvinikym <[email protected]> * And more Signed-off-by: Akvinikym <[email protected]> * Refactored switch-case Signed-off-by: Akvinikym <[email protected]>
* Introduced error codes to SQL Signed-off-by: Akvinikym <[email protected]> * Builds Signed-off-by: Akvinikym <[email protected]> * 4/16 commands Signed-off-by: Akvinikym <[email protected]> * 13/16 done Signed-off-by: Akvinikym <[email protected]> * Tests are finished Signed-off-by: Akvinikym <[email protected]> * Review issues Signed-off-by: Akvinikym <[email protected]> * Introduced error codes to SFV Signed-off-by: Akvinikym <[email protected]> * Is now built Signed-off-by: Akvinikym <[email protected]> * Added a separated function for parsing SQL errors and making an error Signed-off-by: Akvinikym <[email protected]> * Review issues are addressed Signed-off-by: Akvinikym <[email protected]> * Added ToDos Signed-off-by: Akvinikym <[email protected]> * Some after-POW issues Signed-off-by: Akvinikym <[email protected]> * Error codes has good ordering Signed-off-by: Akvinikym <[email protected]> * More fixes Signed-off-by: Akvinikym <[email protected]> * Build fix Signed-off-by: Akvinikym <[email protected]> * And more Signed-off-by: Akvinikym <[email protected]> * Refactored switch-case Signed-off-by: Akvinikym <[email protected]>
* Introduced error codes to SQL Signed-off-by: Akvinikym <[email protected]> * Builds Signed-off-by: Akvinikym <[email protected]> * 4/16 commands Signed-off-by: Akvinikym <[email protected]> * 13/16 done Signed-off-by: Akvinikym <[email protected]> * Tests are finished Signed-off-by: Akvinikym <[email protected]> * Review issues Signed-off-by: Akvinikym <[email protected]> * Introduced error codes to SFV Signed-off-by: Akvinikym <[email protected]> * Is now built Signed-off-by: Akvinikym <[email protected]> * Error code is introduced, and tests are up Signed-off-by: Akvinikym <[email protected]> * Added a separated function for parsing SQL errors and making an error Signed-off-by: Akvinikym <[email protected]> * Review issues are addressed Signed-off-by: Akvinikym <[email protected]> * Added ToDos Signed-off-by: Akvinikym <[email protected]> * Some after-POW issues Signed-off-by: Akvinikym <[email protected]> * Error codes has good ordering Signed-off-by: Akvinikym <[email protected]> * More fixes Signed-off-by: Akvinikym <[email protected]> * Build fix Signed-off-by: Akvinikym <[email protected]> * And more Signed-off-by: Akvinikym <[email protected]> * Refactored switch-case Signed-off-by: Akvinikym <[email protected]> * Review issues are fixed Signed-off-by: Akvinikym <[email protected]> * Little issue Signed-off-by: Akvinikym <[email protected]> * Another issue Signed-off-by: Akvinikym <[email protected]>
muratovv
approved these changes
Nov 13, 2018
nickaleks
approved these changes
Nov 14, 2018
| }; | ||
| case TxStatusType::kEnoughSignaturesCollected: { | ||
| builder = builder.enoughSignaturesCollected(); | ||
| break; | ||
| status_bus_->publish(status_factory_->makeEnoughSignaturesCollected(hash, tx_error)); |
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR trunk introduces error codes for stateful response. Numeric values, described in the following POW, are returned the to the client instead of long and insecure error messages.
Benefits
More security and easier to parse by the client.
Possible Drawbacks
Less information about the error, which happened during validation.