Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add connectionless end-to-end tests #342

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: add connectionless end-to-end tests #342

wants to merge 2 commits into from

Conversation

chereseeriepa
Copy link
Contributor

Description:

This PR adds end-to-end tests for connectionless credential issuance and presentation/verification.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@chereseeriepa chereseeriepa force-pushed the cherese/connectionless-tests branch from cf145f4 to c48399d Compare November 18, 2024 03:44
@chereseeriepa chereseeriepa changed the title test: add connectionless issuance end-to-end test test: add connectionless end-to-end tests Nov 18, 2024
@chereseeriepa chereseeriepa force-pushed the cherese/connectionless-tests branch from c48399d to f28fbaf Compare November 18, 2024 03:49
@chereseeriepa
Copy link
Contributor Author

This was my first time coming across Serenity js and cucumber, so bare with me :)

@chereseeriepa chereseeriepa force-pushed the cherese/connectionless-tests branch 2 times, most recently from e660883 to 28f611d Compare November 18, 2024 19:43
@chereseeriepa chereseeriepa force-pushed the cherese/connectionless-tests branch from 28f611d to 02a3d6c Compare November 18, 2024 19:46
@chereseeriepa chereseeriepa marked this pull request as ready for review November 18, 2024 19:48
@chereseeriepa chereseeriepa requested a review from a team as a code owner November 18, 2024 19:48
amagyar-iohk
amagyar-iohk reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@amagyar-iohk amagyar-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chereseeriepa thanks for your contribution! Could you update this branch?

Thanks

@elribonazo
Copy link
Contributor

@mixmix @chereseeriepa Can u guys pick this up? If not we may just close this PR and re-open if there's new activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amagyar-iohk amagyar-iohk amagyar-iohk left review comments

@curtis-h curtis-h curtis-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chereseeriepa @elribonazo @curtis-h @amagyar-iohk