Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add listener async + wait time for presentation verified #336

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: add listener async + wait time for presentation verified #336

merged 3 commits into from
Nov 13, 2024

Conversation

elribonazo
Copy link
Contributor

Description:

workshop improvements

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo requested a review from a team as a code owner November 13, 2024 13:30
@elribonazo
fix: last step
c2302cd 
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 75%
 76.08% (3633/4775) 66.49% (1665/2504) 80.29% (864/1076)

@elribonazo
fix: last step fix
fb1d35b 
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo merged commit 80f3370 into main Nov 13, 2024
5 checks passed
@elribonazo elribonazo deleted the fix/workshop-fixes branch November 13, 2024 13:42
jeyem pushed a commit to socious-io/identus-edge-agent-sdk-ts that referenced this pull request Dec 12, 2024
@elribonazo @jeyem
fix: add listener async + wait time for presentation verified (hyperl…
ac3532d 
…edger-identus#336)

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvoiturier bvoiturier bvoiturier approved these changes

@mineme0110 mineme0110 mineme0110 approved these changes

@amagyar-iohk amagyar-iohk amagyar-iohk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elribonazo @bvoiturier @mineme0110 @amagyar-iohk