fix: adding esbuild also as optional missing dependency #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: sending a didcomm message event when oob message is parsed Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
force-pushed
the
fix/oob_notify_new_message
branch
from
7bf76b8 to
5043ed9
Compare
|
Pull Request Test Coverage Report for Build 11692481940Details
💛 - Coveralls |
mineme0110
approved these changes
Nov 5, 2024
curtis-h
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
curtis-h
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
curtis-h
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]> Signed-off-by: Curtish <[email protected]>
curtis-h
added a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]> Signed-off-by: Curtish <[email protected]> Co-authored-by: Javier Ribó <[email protected]>
jeyem
pushed a commit
to socious-io/identus-edge-agent-sdk-ts
that referenced
this pull request
Dec 12, 2024
…identus#324) Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding this change by default in the SDK will allow me to run a smooth demo.
During the development of the demo I was missing something and I found out that in our SDK, after parsing a OOB message we stored it but didn't emit the new message event.
This directly affects how people use the code, is needed to make the Hyperledger workshop smoother and not have people build the SDK from source!
Checklist: