Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maximum-rate controller #874

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Add maximum-rate controller #874

merged 1 commit into from
Jun 25, 2020

Conversation

nklincoln
Copy link
Contributor

Signed-off-by: [email protected] [email protected]

Contributes to #870

  • Ramp the worker TPS conditionally between txUpdate phases, if a TPS drop (for an increased driving rate) is detected, back off and reduce the ramp

@nklincoln nklincoln mentioned this pull request Jun 23, 2020
Merged
aklenik
aklenik requested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a general question: if this is called the maximum-rate controller, what will we call the one which enables the next TX without any condition? Stress-rate perhaps? 😀

packages/caliper-core/lib/worker/rate-control/maxRate.js Outdated Show resolved Hide resolved
packages/caliper-core/lib/worker/rate-control/maxRate.js Outdated Show resolved Hide resolved
packages/caliper-core/lib/worker/rate-control/maxRate.js Outdated Show resolved Hide resolved
@nklincoln nklincoln force-pushed the max-rate-controller branch from 4b23c7c to 53496e1 Compare June 25, 2020 07:28
aklenik
aklenik approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aklenik aklenik merged commit 0ab2be4 into hyperledger-caliper:master Jun 25, 2020
@nklincoln nklincoln deleted the max-rate-controller branch June 25, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aklenik aklenik aklenik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklincoln @aklenik