Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: disallow http(s) RPC transports #829

Merged
merged 2 commits into from
May 10, 2020

Conversation

benjamincburns
Copy link
Contributor

@benjamincburns benjamincburns commented May 6, 2020

Fixes #776. See #776 (comment) for more info.

Signed-off-by: Ben Burns [email protected]

@benjamincburns
Copy link
Contributor Author

benjamincburns commented May 6, 2020

The CI errors appear to be caused by something to do with the prometheus observer.

Unless there's some code in those tests that uses the ethereum adapter via an HTTP provider, it's impossible that this change could have caused this error. I have double checked for usages of caliper-ethereum in the failing tests (in caliper-core) just to be sure.

@benjamincburns
Copy link
Contributor Author

My apologies - I missed the linter errors - should be fixed up now.

@nklincoln
Copy link
Contributor

There's a connection error showing at the moment - is this a port mismatch? The config files (docker compose) used in the integration test are exposing/mapping a single port (8545) rather than a port range as done in besu, and there has been a change in the network config files to be 8546

(https://github.com/hyperledger/caliper/blob/9b571dd2f48ef745ff929c1cb1daebeaa998dae7/packages/caliper-tests-integration/ethereum_tests/config/docker-compose.yml#L26)

@benjamincburns
Copy link
Contributor Author

There's a connection error showing at the moment - is this a port mismatch? The config files (docker compose) used in the integration test are exposing/mapping a single port (8545) rather than a port range as done in besu, and there has been a change in the network config files to be 8546

(

https://github.com/hyperledger/caliper/blob/9b571dd2f48ef745ff929c1cb1daebeaa998dae7/packages/caliper-tests-integration/ethereum_tests/config/docker-compose.yml#L26

)

Good catch - I forgot to change the exposed port.

Signed-off-by: Ben Burns <[email protected]>
@nklincoln nklincoln merged commit ac0ad27 into hyperledger-caliper:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum adapter needs better nonce management
2 participants