Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Besu Support #786

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Update Besu Support #786

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d055b03
Update Besu Support
shemnon Apr 3, 2020
9f2e9aa
ymal changes
shemnon Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/caliper-cli/lib/lib/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,6 @@ sut:
besu:
1.3.2: &besu-latest
packages: ['[email protected]']
1.3: *besu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besu-latest should only be applied to 1.4 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a YAML expert. How should this look? All of 1.3.2, 1.3, 1.4, and latest use the exact same dependencies. & is a reference and * is an expansion of that reference. Do you want a different name or do I not understand the syntax?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the YAML is correct. Although, it is a bit confusing to read that the besu-latest anchor is used as an alias at multiple places.

  1. The quick&dirty solution is to list the package explicitly at both places, then put the besu-latest anchor to 1.4 and use the alias at latest. This will allow the independent modification of 1.3 and 1.4 dependencies (whether it'll be needed, that's another question).
  2. If you don't want to duplicate entries, place a single packages: [...] entry at the top of the file, under an attribute and anchor like besu-web3-1.2.0, and reference it for 1.3 and 1.4, while also attaching the besu-latest anchor to 1.4 (hopefully anchors and aliases at the same place are supported). Although it seems a bit overengineered for the current situation.

My take on this is to go for readability (1). Listing the package at both places is not the end of the world, but it's easier to read.

1.4: *besu-latest
latest: *besu-latest