Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis badge in README and simplify package README handling #738

Closed
wants to merge 1 commit into from
Closed

Fix Travis badge in README and simplify package README handling #738

wants to merge 1 commit into from

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Feb 19, 2020

Signed-off-by: Attila Klenik [email protected]

  • The Travis badge now points to the .com site
  • The package READMEs have been removed. The publishing script copies the root README into every published package directory. So only one README to maintain.

@nklincoln nklincoln self-assigned this Feb 19, 2020
nklincoln
nklincoln approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 big +1 for removal of code clutter

@aklenik
Copy link
Contributor Author

aklenik commented Feb 20, 2020

Already merged, but github left this open...

@aklenik aklenik closed this Feb 20, 2020
@aklenik aklenik deleted the readme-fix branch February 21, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklincoln nklincoln nklincoln approved these changes

@feihujiang feihujiang Awaiting requested review from feihujiang

@jiangyaoguo jiangyaoguo Awaiting requested review from jiangyaoguo

@liam-grace liam-grace Awaiting requested review from liam-grace

@panyu4 panyu4 Awaiting requested review from panyu4

Assignees

@nklincoln nklincoln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aklenik @nklincoln