Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass transient data and peer targets to a gateway tran… #713

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Add ability to pass transient data and peer targets to a gateway tran… #713

merged 1 commit into from
Jan 23, 2020

Conversation

nklincoln
Copy link
Contributor

This PR enhances the V2 Fabric Gateway:

  • Condense the code path to use a single method performGatewayTransaction that has a boolean flag for submit/evaluate
  • Enable extraction of transient data from a benchmark test
  • Enable extraction of target peers from a benchmark test

Signed-off-by: [email protected] [email protected]

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@nklincoln nklincoln added the enhancement New feature or request label Jan 21, 2020
lynn14m
lynn14m approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@lynn14m lynn14m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklincoln nklincoln merged commit 1e4f1e3 into hyperledger-caliper:master Jan 23, 2020
@nklincoln nklincoln deleted the transient-data branch January 23, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynn14m lynn14m lynn14m approved these changes

@aklenik aklenik Awaiting requested review from aklenik

@feihujiang feihujiang Awaiting requested review from feihujiang

@jiangyaoguo jiangyaoguo Awaiting requested review from jiangyaoguo

@liam-grace liam-grace Awaiting requested review from liam-grace

@panyu4 panyu4 Awaiting requested review from panyu4

Assignees

@lynn14m lynn14m

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklincoln @lynn14m