Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Ethereum fromAddressSeed option #666

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Nov 22, 2019

Document the fromAddressSeed option and priority of configurations.

Signed-off-by: Danno Ferrin [email protected]

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

Document the `fromAddressSeed` option and priority of configurations.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon mentioned this pull request Nov 22, 2019
9 tasks
@nklincoln nklincoln self-assigned this Nov 25, 2019
@nklincoln nklincoln added the PR/under review The PR is currently under review label Nov 25, 2019
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nklincoln nklincoln merged commit cd00958 into hyperledger-caliper:gh-pages Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/under review The PR is currently under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants