Enable charts to be included in output report #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklincoln
requested review from
feihujiang,
jiangyaoguo,
liam-grace and
panyu4
as code owners
Merged
nklincoln
force-pushed
the
enable-report-charting
branch
2 times, most recently
from
97dbd31 to
c3a8061
Compare
nklincoln
force-pushed
the
enable-report-charting
branch
from
c3a8061 to
e709c4c
Compare
aklenik
requested changes
Nov 27, 2019
| * @param {string} callingMonitor the calling class name used to create a UUID | ||
| * @param {string} testLabel the current test label, required for creating a UUID | ||
| * @param {string[]} includeMetrics the metrics to include in the chart | ||
| * @param {Map<string, string>} resourceStats all resource stats |
There was a problem hiding this comment.
Param type should be Map<string, string>[]
aklenik
added
the
PR/change requested
- Breaking changes in monitor configuration for docker and process monitors - Report styling change - Addition of charts to output report (opt in per monitor) - Conversion of report tables to be normalized to a single metric - Report presicion now a user config item Signed-off-by: [email protected] <[email protected]>
nklincoln
force-pushed
the
enable-report-charting
branch
from
e709c4c to
3fcec80
Compare
aklenik
removed
PR/change requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides enhanced report outputs for a user
Breaking changes:
namefilter changed tocontainer, to better reflect what it is filteringprocessesblockOther Changes:
Signed-off-by: [email protected] [email protected]