Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throughput faq #1656

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: throughput faq #1656

merged 3 commits into from
Nov 22, 2024

Conversation

psankhe28
Copy link
Contributor

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

#1418

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

davidkel
davidkel requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to add send rate back in

@psankhe28
changed faq
dc4e496 
Signed-off-by: Prati28 <[email protected]>
@psankhe28 psankhe28 requested a review from davidkel November 22, 2024 10:50
davidkel
davidkel requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there, have done some tidyup to provide a recommendation.

docs/source/getting-started/faq.md Outdated Show resolved Hide resolved
@psankhe28
changes
c6ba5b1 
Signed-off-by: Prati28 <[email protected]>
@psankhe28 psankhe28 requested a review from davidkel November 22, 2024 17:37
davidkel
davidkel approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Many thanks

@davidkel davidkel merged commit 19d46db into hyperledger-caliper:main Nov 22, 2024
10 checks passed
@psankhe28 psankhe28 deleted the faq branch November 24, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psankhe28 @davidkel