-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: record rate doc section #1653
Conversation
Signed-off-by: Prati28 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this really addresses the issue here and is also confusing.
- For the text format
- we should just state that the value of i will start at zero, so the first line represents 0 transactions submitted. Each value in a line represents time in milliseconds from the start of the round
- For the binary format
- The first entry length is the total number of transactions submitted (it isn't
so far
) as it's a final output - remove the line that starts
if no transactions have been submitted.....
this is not correct - the subsequent values (Uint32 values in Big Endian or Little Endian format) represent time in milliseconds from the start of the round. Each entry corresponds to the number of transactions submitted starting from 0
Signed-off-by: Prati28 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes required, suggestions are in the comments
Signed-off-by: Prati28 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Many thanks
Checklist
Issue/User story
#1635
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request