FIX #1570: Enhance the test coverage of fixedRate controller. #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
|
@davidkel PTAL If the issue is feasible. |
|
@rahat2134 Your DCO sign-off is incorrect, please fix that, otherwise we can't consider the PR for merging. |
Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
This reverts commit 1a453f5. Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
This commit adds additional test suites for the fixedRate functionality to enhance test coverage. Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
* add all the tests Signed-off-by: Eshaan Aggarwal <[email protected]> * add tests for false case Signed-off-by: Eshaan Aggarwal <[email protected]> --------- Signed-off-by: Eshaan Aggarwal <[email protected]>
Signed-off-by: Dave Kelsey <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
downgrade the version of npm on the publish step to ensure that publish doesn't give an ENOWORKSPACES error This should be considered a temporary solution to getting publish working again and a better solution needs to be found. Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
This rationalises the versions and we should only document the following binding versions 1, 1.4 (use 1.4 legacy sdk) 2.2 (use 2.2 legacy sdk) 2.4, 2.5, 3, fabric-gateway (use the fabric-gateway sdk) We will keep 2.4 (for legacy reasons only as 2.4 was never LTS), 2.5 to cover the published versions of fabric we support however the binding of fabric-gateway should be the one going forward and seen in the documentation. because Fabric 2 changed the recommended client version in a point release (2.5 deprecated the legacy sdks and the only real option if the fabric-gateway) otherwise we will specify a single digit version for fabric (1,3) the 1.4, 2.2 sdks are now deprecated and 2.2 is now or version soon to be out of lts, therefore fabric-gateway is the only version that will and should be used in the future and there is no plan to change the client side much given the reduction in resource of people using it and the use of SmartBFT should not affect the client side version (I hope :-) ) Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: Vinayak Raj Ranjan <[email protected]> Signed-off-by: rahat2134 <[email protected]>
…1538 (#1540) * Update PSWG whitepaper link in README Signed-off-by: Vinayak Raj Ranjan <[email protected]> * remove Caliper-gui-server packages and Caliper-gui-dashboard packages Signed-off-by: Vinayak Raj Ranjan <[email protected]> * Remove unwanted file regarding to Caliper-gui-server packages and Caliper-gui-dashboard packages Signed-off-by: Vinayak Raj Ranjan <[email protected]> --------- Signed-off-by: Vinayak Raj Ranjan <[email protected]> Signed-off-by: rahat2134 <[email protected]>
reasons for this 1. we have never documented the metrics 2. not sure how much use it is anyway 3. was using an old version of gc-stats which is now unmaintained and has security issues 4. replacement version of gc-stats is maintained by a single person who controls the binary builds available so is a dangerous thing to rely on 5. it has no pure javascript fallback therefore requires caliper to pull down or build a binary module (meaning you need python and compilers installed) which will also be dependent on the version of node being used. Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
* removed unused dependencies Signed-off-by: Prati28 <[email protected]> * removed the package Signed-off-by: Prati28 <[email protected]> --------- Signed-off-by: Prati28 <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
This reverts commit 1a453f5. Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
This commit adds additional test suites for the fixedRate functionality to enhance test coverage. Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
* add all the tests Signed-off-by: Eshaan Aggarwal <[email protected]> * add tests for false case Signed-off-by: Eshaan Aggarwal <[email protected]> --------- Signed-off-by: Eshaan Aggarwal <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
This reverts commit 1a453f5. Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: Dave Kelsey <[email protected]> Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
Signed-off-by: rahat2134 <[email protected]>
|
correcting sign-off, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #1570
Checklist
Existing issues
No
Automated Tests
Enhance the tests.