-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove References to Fisco-bcos from VNext Documentation #1528 #1533
Conversation
Signed-off-by: Vinayak Raj Ranjan <[email protected]>
Signed-off-by: Vinayak Raj Ranjan <[email protected]>
Signed-off-by: Vinayak Raj Ranjan <[email protected]>
Signed-off-by: Vinayak Raj Ranjan <[email protected]>
Hey @davidkel I remove References to Fisco-bcos from VNext Documentation , But we comment some line of code in config file. I not remove it because I am not sure it is useful or not So please review my pr if any changes required let me know ,Thank You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinayakjaas Unfortunately there are a lot more references to fisco-bcos than just 2 files in vNext. You really need to go through the documentation source to find everything that references fisco-bcos. We can delete the FISCO_BCOS_Configuration.md file rather than comment it out. The files I found were
- Architecture.md
- Caliper_FAQ.md (note it's incorrectly spelt)
- CONTRIBUTING.md
- FISCO_BCOS_Configuration.md
- Getting_Started.md
- Installing_Caliper.md
As with other connectors we have removed we will need to remove the fisco-bcos logo from the main page but that should be done when the next version of caliper is released so will need a new issue raised to cover that.
Signed-off-by: Vinayak Raj Ranjan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution
Checklist
Issue/User story
This pull request resolves issue #1528
Screenshot
Before Correction
After Correction