Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove References to Fisco-bcos from VNext Documentation #1528 #1533

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

vinayakjaas
Copy link
Contributor

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working

Issue/User story

This pull request resolves issue #1528

Screenshot

Before Correction

Screenshot 2024-04-11 130540

After Correction

Screenshot 2024-04-11 130759

@vinayakjaas
Copy link
Contributor Author

Hey @davidkel I remove References to Fisco-bcos from VNext Documentation , But we comment some line of code in config file. I not remove it because I am not sure it is useful or not So please review my pr if any changes required let me know ,Thank You

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakjaas Unfortunately there are a lot more references to fisco-bcos than just 2 files in vNext. You really need to go through the documentation source to find everything that references fisco-bcos. We can delete the FISCO_BCOS_Configuration.md file rather than comment it out. The files I found were

  • Architecture.md
  • Caliper_FAQ.md (note it's incorrectly spelt)
  • CONTRIBUTING.md
  • FISCO_BCOS_Configuration.md
  • Getting_Started.md
  • Installing_Caliper.md

As with other connectors we have removed we will need to remove the fisco-bcos logo from the main page but that should be done when the next version of caliper is released so will need a new issue raised to cover that.

@vinayakjaas vinayakjaas requested a review from davidkel April 12, 2024 14:32
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@davidkel davidkel merged commit 2cae2fe into hyperledger-caliper:gh-pages Apr 15, 2024
2 checks passed
@davidkel davidkel linked an issue Apr 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to Fisco-bcos from the vNext documentation
2 participants